logos-storage/nim-json-rpc
1
0
Fork 0
mirror of https://github.com/logos-storage/nim-json-rpc.git synced 2026-02-24 07:33:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor comment changes

Browse Source
This commit is contained in:
coffeepots 2018-03-02 11:54:21 +00:00
parent bc375ad817
commit 938a601b77
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/server/serverdispatch.nim
View File

@ -20,8 +20,7 @@ proc processMessage(server: RpcServer, client: AsyncSocket, line: string) {.asyn
if not server.procs.hasKey(methodName):
await client.sendError(METHOD_NOT_FOUND, "Method not found", id, %(methodName & " is not a registered method."))
else:
# TODO: Performance or other effects from NOT calling rpc with await?
let callRes = server.procs[methodName](node["params"])
let callRes = server.procs[methodName](node["params"]) # TODO: Performance or other effects from NOT calling rpc with await?
await client.send($wrapReply(id, callRes, newJNull()) & "\c\l")
proc processClient(server: RpcServer, client: AsyncSocket) {.async.} =
@ -39,8 +38,7 @@ proc processClient(server: RpcServer, client: AsyncSocket) {.async.} =
await fut
if fut.failed:
if fut.readError of RpcProcError:
# This error signifies that the proc wants us to respond with a custom
# error object.
# TODO: Currently exceptions in rpc calls are not properly handled
let err = fut.readError.RpcProcError
await client.sendError(err.code, err.msg, err.data)
else: