logos-storage/nim-json-rpc
1
0
Fork 0
mirror of https://github.com/logos-storage/nim-json-rpc.git synced 2026-05-22 10:29:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add max line length

Browse Source
This commit is contained in:
coffeepots 2018-06-12 19:26:24 +01:00
parent 93c7a5577e
commit 937546b71d
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
eth-rpc/client.nim
View File

@ -10,6 +10,8 @@ type
nextId: int64 nextId: int64
Response* = tuple[error: bool, result: JsonNode] Response* = tuple[error: bool, result: JsonNode]
const maxRequestLength = 1024 * 128
proc newRpcClient*(): RpcClient = proc newRpcClient*(): RpcClient =
## Creates a new ``RpcClient`` instance. ## Creates a new ``RpcClient`` instance.
result = RpcClient(awaiting: initTable[string, Future[Response]](), nextId: 1) result = RpcClient(awaiting: initTable[string, Future[Response]](), nextId: 1)
@ -36,7 +38,7 @@ macro checkGet(node: JsonNode, fieldName: string,
let n = genSym(ident = "n") #`node`{`fieldName`} let n = genSym(ident = "n") #`node`{`fieldName`}
result = quote: result = quote:
let `n` = `node`{`fieldname`} let `n` = `node`{`fieldname`}
if `n`.isNil: if `n`.isNil or `n`.kind == JNull:
raise newException(ValueError, raise newException(ValueError,
"Message is missing required field \"" & `fieldName` & "\"") "Message is missing required field \"" & `fieldName` & "\"")
if `n`.kind != `jKind`.JsonNodeKind: if `n`.kind != `jKind`.JsonNodeKind:
@ -79,10 +81,7 @@ proc connect*(self: RpcClient, address: string, port: Port): Future[void]
proc processData(self: RpcClient) {.async.} = proc processData(self: RpcClient) {.async.} =
while true: while true:
# read until no data let line = await self.transp.readLine(maxRequestLength)
# TODO: we need to limit number of bytes we going to read, without any
# limits server can fill all memory it can here.
let line = await self.transp.readLine()
if line == "": if line == "":
# transmission ends # transmission ends
self.transp.close() self.transp.close()