logos-storage/nim-json-rpc
1
0
Fork 0
mirror of https://github.com/logos-storage/nim-json-rpc.git synced 2026-05-01 16:33:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

avoid failing uninitialized Future (#212)

Browse Source 
In #195, a regression got introduced where an uninitialized `requestFut`
gets `fail()`-ed if the message's `id` cannot be found in pending list.
Revert back to return an `err()` instead, as before.
This commit is contained in:
Etan Kissling 2024-02-17 09:02:20 +01:00 committed by GitHub
parent a7e68ec059
commit 171c747584
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
json_rpc/client.nim
View File

@ -174,9 +174,7 @@ proc processMessage*(client: RpcClient, line: string): Result[void, string] =
var requestFut: Future[JsonString]
let id = response.id.get
if not client.awaiting.pop(id, requestFut):
let msg = "Cannot find message id \"" & $id & "\":"
requestFut.fail(newException(JsonRpcError, msg))
return ok()
return err("Cannot find message id \"" & $id & "\"")
if response.error.isSome:
let error = JrpcSys.encode(response.error.get)
@ -266,4 +264,3 @@ macro createRpcSigsFromNim*(clientType: untyped, procList: untyped): untyped =
processRpcSigs(clientType, procList)
{.pop.}