From 44d6cf49d2d29125bbfe7be53cd439de32027d6b Mon Sep 17 00:00:00 2001 From: Arnaud Date: Thu, 27 Mar 2025 09:02:02 +0100 Subject: [PATCH] Update log filters comment --- ethers/providers/jsonrpc/subscriptions.nim | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/ethers/providers/jsonrpc/subscriptions.nim b/ethers/providers/jsonrpc/subscriptions.nim index f869837..3602a55 100644 --- a/ethers/providers/jsonrpc/subscriptions.nim +++ b/ethers/providers/jsonrpc/subscriptions.nim @@ -22,10 +22,11 @@ type client: RpcClient callbacks: Table[JsonNode, SubscriptionCallback] methodHandlers: Table[string, MethodHandler] - # We need to keep around the filters that are used to create log filters on the RPC node - # as there might be a time when they need to be recreated as RPC node might prune/forget - # about them - # This is used of resubscribe all the subscriptions when using websocket with hardhat + # Used by both PollingSubscriptions and WebsocketSubscriptions to store + # subscription filters so the subscriptions can be recreated. With + # PollingSubscriptions, the RPC node might prune/forget about them, and with + # WebsocketSubscriptions, when using hardhat, subscriptions are dropped after 5 + # minutes. logFilters: Table[JsonNode, EventFilter] when defined(ws_resubscribe): resubscribeFut: Future[void]