logos-storage/nim-ethers
1
0
Fork 0
mirror of https://github.com/logos-storage/nim-ethers.git synced 2026-01-06 23:53:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(jsonrpc): propagate cancelled error in call

Browse Source 
- CancelledError was being swallowed by except CatchableError
This commit is contained in:
Eric 2024-12-13 14:39:20 +11:00
parent 0f98528758
commit 1ba4b2c51e
No known key found for this signature in database
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ethers/providers/jsonrpc.nim
View File

@ -88,10 +88,16 @@ proc new*(
proc callImpl(
client: RpcClient,
call: string,
args: JsonNode): Future[JsonNode] {.async: (raises: [JsonRpcProviderError]).} =
args: JsonNode): Future[JsonNode] {.async: (raises: [CancelledError, JsonRpcProviderError]).} =
var response: JsonString
try:
response = await client.call(call, %args)
except CancelledError as e:
raise e
except CatchableError as e:
raiseJsonRpcProviderError e.msg
without response =? (await client.call(call, %args)).catch, error:
raiseJsonRpcProviderError error.msg
without json =? JsonNode.fromJson(response.string), error:
raiseJsonRpcProviderError "Failed to parse response: " & error.msg
json