From a23ec47b249e0b38b80be31e08530062af6f102d Mon Sep 17 00:00:00 2001 From: Jaremy Creechley Date: Tue, 5 Sep 2023 13:51:22 -0700 Subject: [PATCH] more docs --- datastore/threadproxyds.nim | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/datastore/threadproxyds.nim b/datastore/threadproxyds.nim index 8064b8a..159b90c 100644 --- a/datastore/threadproxyds.nim +++ b/datastore/threadproxyds.nim @@ -138,13 +138,13 @@ method query*( ret.failure(err) var iter = newSharedPtr(QueryIterStore) - ## note that bypasses SharedPtr isolation - may need `protect` here? + ## does this bypasses SharedPtr isolation? - may need `protect` here? iter[].it = it var iterWrapper = QueryIter.new() proc next(): Future[?!QueryResponse] {.async.} = - print "query:next:start: " + # print "query:next:start: " iterWrapper.finished = iter[].it.finished if not iter[].it.finished: query(ret, self.tds, iter) @@ -191,6 +191,7 @@ proc newThreadProxyDatastore*( var self = ThreadProxyDatastore() let value = newSharedPtr(ThreadDatastore) # GC_ref(ds) ## TODO: is this needed? + try: value[].ds = ds value[].tp = Taskpool.new(num_threads = 2)