logos-storage/nim-datastore
1
0
Fork 0
mirror of https://github.com/logos-storage/nim-datastore.git synced 2026-01-04 14:43:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor repeated "check column metadata" code into a template

Browse Source
This commit is contained in:
Michael Bradley, Jr 2022-07-11 08:02:48 -05:00
parent 9131323747
commit 89051a38ea
No known key found for this signature in database
GPG Key ID: D0307DBCF21A9A58
1 changed files with 17 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
datastore/sqlite_datastore.nim
View File

@ -97,24 +97,26 @@ const
) VALUES (?, ?, ?);
"""
template checkColMetadata(s: RawStmtPtr, i: int, expectedName: string) =
let
colName = sqlite3_column_origin_name(s, i.cint)
if colName.isNil:
raise (ref Defect)(msg: "no column exists for index " & $i)
if $colName != expectedName:
raise (ref Defect)(msg: "original column name for index " & $i & " was \"" &
$colName & "\" but expected \"" & expectedName & "\"")
proc idCol*(
s: RawStmtPtr,
index = idColIndex): BoundIdCol =
let
i = index.cint
colName = sqlite3_column_origin_name(s, i)
if colName.isNil:
raise (ref Defect)(msg: "no column exists for index " & $index)
if $colName != idColName:
raise (ref Defect)(msg: "original column name for index " & $index &
" was \"" & $colName & "\" but expected \"" & idColName & "\"")
checkColMetadata(s, index, idColName)
return proc (): string =
let
text = sqlite3_column_text(s, i)
text = sqlite3_column_text(s, index.cint)
# detect out-of-memory error
# see the conversion table and final paragraph of:
@ -134,19 +136,11 @@ proc dataCol*(
s: RawStmtPtr,
index = dataColIndex): BoundDataCol =
let
i = index.cint
colName = sqlite3_column_origin_name(s, i)
if colName.isNil:
raise (ref Defect)(msg: "no column exists for index " & $index)
if $colName != dataColName:
raise (ref Defect)(msg: "original column name for index " & $index &
" was \"" & $colName & "\" but expected \"" & dataColName & "\"")
checkColMetadata(s, index, dataColName)
return proc (): seq[byte] =
let
i = index.cint
blob = sqlite3_column_blob(s, i)
# detect out-of-memory error
@ -183,19 +177,10 @@ proc timestampCol*(
s: RawStmtPtr,
index = timestampColIndex): BoundTimestampCol =
let
i = index.cint
colName = sqlite3_column_origin_name(s, i)
if colName.isNil:
raise (ref Defect)(msg: "no column exists for index " & $index)
if $colName != timestampColName:
raise (ref Defect)(msg: "original column name for index " & $index &
" was \"" & $colName & "\" but expected \"" & timestampColName & "\"")
checkColMetadata(s, index, timestampColName)
return proc (): int64 =
sqlite3_column_int64(s, i)
sqlite3_column_int64(s, index.cint)
proc new*(
T: type SQLiteDatastore,