logos-storage/nim-datastore
1
0
Fork 0
mirror of https://github.com/logos-storage/nim-datastore.git synced 2026-01-08 16:43:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Addressing review comments by Dmitriy

Browse Source
This commit is contained in:
Tomasz Bekas 2024-05-08 19:23:31 +02:00
parent 50b480270f
commit 6136eb608d
No known key found for this signature in database
GPG Key ID: 4854E04C98824959
2 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
datastore/typedds.nim
View File

@ -20,7 +20,7 @@ import ./datastore
## import pkg/questionable ## import pkg/questionable
## ##
## let ## let
## tds = ds.asTypedDs() ## tds = TypeDatastore.init(ds)
## key = Key.init("p").tryGet() ## key = Key.init("p").tryGet()
## ##
## type Person = object ## type Person = object
@ -54,17 +54,13 @@ type
# Helpers # Helpers
template requireDecoder*(T: typedesc): untyped = template requireDecoder*(T: typedesc): untyped =
when (compiles do: when not (compiles do:
let _: ?!T = T.decode(newSeq[byte]())): let _: ?!T = T.decode(newSeq[byte]())):
discard
else:
{.error: "provide a decoder: `proc decode(T: type " & $T & ", bytes: seq[byte]): ?!T`".} {.error: "provide a decoder: `proc decode(T: type " & $T & ", bytes: seq[byte]): ?!T`".}
template requireEncoder*(T: typedesc): untyped = template requireEncoder*(T: typedesc): untyped =
when (compiles do: when not (compiles do:
let _: seq[byte] = encode(default(T))): let _: seq[byte] = encode(default(T))):
discard
else:
{.error: "provide an encoder: `proc encode(a: " & $T & "): seq[byte]`".} {.error: "provide an encoder: `proc encode(a: " & $T & "): seq[byte]`".}
# Original Datastore API # Original Datastore API
@ -83,11 +79,10 @@ proc delete*(self: TypedDatastore, keys: seq[Key]): Future[?!void] {.async.} =
proc close*(self: TypedDatastore): Future[?!void] {.async.} = proc close*(self: TypedDatastore): Future[?!void] {.async.} =
await self.ds.close() await self.ds.close()
# Conversion Datastore -> TypeDatastore # TypedDatastore API
proc asTypedDs*(ds: Datastore): TypedDatastore = proc init*(T: type TypedDatastore, ds: Datastore): T =
TypedDatastore(ds: ds) TypedDatastore(ds: ds)
# TypedDatastore API
proc put*[T](self: TypedDatastore, key: Key, t: T): Future[?!void] {.async.} = proc put*[T](self: TypedDatastore, key: Key, t: T): Future[?!void] {.async.} =
requireEncoder(T) requireEncoder(T)

4
tests/datastore/typeddscommontests.nim
View File

@ -33,7 +33,7 @@ proc typedDsTests*(
key: Key, key: Key,
dsCount = 1) = dsCount = 1) =
let tds: TypedDatastore = ds.asTypedDs() let tds = TypedDatastore.init(ds)
test "should put a value": test "should put a value":
(await tds.put(key, 11)).tryGet() (await tds.put(key, 11)).tryGet()
@ -102,7 +102,7 @@ proc typedDsTests*(
proc typedDsQueryTests*(ds: Datastore) = proc typedDsQueryTests*(ds: Datastore) =
let tds = ds.asTypedDs() let tds = TypedDatastore.init(ds)
test "should query values": test "should query values":
let let