From 39c400a87cee69b2c38db878f79c0f066108d303 Mon Sep 17 00:00:00 2001 From: munna0908 Date: Thu, 27 Mar 2025 21:33:39 +0530 Subject: [PATCH] change method signatures --- datastore/datastore.nim | 3 --- datastore/leveldb/leveldbds.nim | 9 ++------- datastore/typedds.nim | 3 --- 3 files changed, 2 insertions(+), 13 deletions(-) diff --git a/datastore/datastore.nim b/datastore/datastore.nim index 3ced9ee..b038165 100644 --- a/datastore/datastore.nim +++ b/datastore/datastore.nim @@ -25,9 +25,6 @@ method delete*(self: Datastore, key: Key): Future[?!void] {.base, gcsafe, locks: method delete*(self: Datastore, keys: seq[Key]): Future[?!void] {.base, gcsafe, locks: "unknown".} = raiseAssert("Not implemented!") -method batchDelete*(self: Datastore, keys: seq[Key]): Future[?!void] {.base, gcsafe, locks: "unknown".} = - raiseAssert("Not implemented!") - method get*(self: Datastore, key: Key): Future[?!seq[byte]] {.base, gcsafe, locks: "unknown".} = raiseAssert("Not implemented!") diff --git a/datastore/leveldb/leveldbds.nim b/datastore/leveldb/leveldbds.nim index 22f29ae..78c2617 100644 --- a/datastore/leveldb/leveldbds.nim +++ b/datastore/leveldb/leveldbds.nim @@ -34,13 +34,8 @@ method delete*(self: LevelDbDatastore, key: Key): Future[?!void] {.async.} = except LevelDbException as e: return failure("LevelDbDatastore.delete exception: " & e.msg) -method delete*(self: LevelDbDatastore, keys: seq[Key]): Future[?!void] {.async.} = - for key in keys: - if err =? (await self.delete(key)).errorOption: - return failure(err.msg) - return success() -method batchDelete*(self: LevelDbDatastore, keys: seq[Key]): Future[?!void] {.async.} = +method delete*(self: LevelDbDatastore, keys: seq[Key]): Future[?!void] {.async.} = try: let b = newBatch() for key in keys: @@ -48,7 +43,7 @@ method batchDelete*(self: LevelDbDatastore, keys: seq[Key]): Future[?!void] {.as self.db.write(b) return success() except LevelDbException as e: - return failure("LevelDbDatastore.batchDelete exception: " & e.msg) + return failure("LevelDbDatastore.delete batch exception: " & e.msg) method get*(self: LevelDbDatastore, key: Key): Future[?!seq[byte]] {.async.} = try: diff --git a/datastore/typedds.nim b/datastore/typedds.nim index adffb9c..21dc2a2 100644 --- a/datastore/typedds.nim +++ b/datastore/typedds.nim @@ -83,9 +83,6 @@ proc delete*(self: TypedDatastore, key: Key): Future[?!void] {.async.} = proc delete*(self: TypedDatastore, keys: seq[Key]): Future[?!void] {.async.} = await self.ds.delete(keys) -proc batchDelete*(self: TypedDatastore, keys: seq[Key]): Future[?!void] {.async.} = - await self.ds.batchDelete(keys) - proc close*(self: TypedDatastore): Future[?!void] {.async.} = await self.ds.close()