From 221e93f3a2502920ce9e4b1b3b5ac0255b3c5c36 Mon Sep 17 00:00:00 2001
From: Dmitriy Ryajov <dryajov@gmail.com>
Date: Thu, 14 Sep 2023 18:05:32 -0600
Subject: [PATCH] remove asyncsemaphore

---
 datastore/threads/threadproxyds.nim | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/datastore/threads/threadproxyds.nim b/datastore/threads/threadproxyds.nim
index 5f58e4d..edf027c 100644
--- a/datastore/threads/threadproxyds.nim
+++ b/datastore/threads/threadproxyds.nim
@@ -22,7 +22,6 @@ import ../query
 import ../datastore
 
 import ./semaphore
-import ./asyncsemaphore
 import ./databuffer
 
 type
@@ -38,8 +37,7 @@ type
   ThreadDatastore* = ref object of Datastore
     tp: Taskpool
     ds: Datastore
-    # semaphore: AsyncSemaphore
-    semaphore: Semaphore
+    semaphore: Semaphore # semaphore is used for backpressure to avoid exhausting file descriptors
     tasks: seq[Future[void]]
 
 template dispatchTask(
@@ -51,7 +49,6 @@ template dispatchTask(
     fut = wait(ctx.signal)
 
   try:
-    # await self.semaphore.acquire()
     self.tasks.add(fut)
     runTask()
     await fut
@@ -68,8 +65,6 @@ template dispatchTask(
       idx != -1):
       self.tasks.del(idx)
 
-    # self.semaphore.release()
-
 proc hasTask(
   ctx: ptr TaskCtx,
   key: ptr Key) =
@@ -336,5 +331,4 @@ func new*(
   success ThreadDatastore(
     tp: tp,
     ds: ds,
-    # semaphore: AsyncSemaphore.new(tp.numThreads - 1)) # one thread is needed for the task dispatcher
-    semaphore: Semaphore.init((tp.numThreads - 1).uint)) # one thread is needed for the task dispatcher
+    semaphore: Semaphore.init((tp.numThreads - 1).uint))