logos-storage/logos-storage-nim
1
0
Fork 0
mirror of https://github.com/logos-storage/logos-storage-nim.git synced 2026-01-09 08:53:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

readd prevention of hanging when closing process streams on windows

Browse Source
This commit is contained in:
Eric 2025-03-07 16:25:16 +11:00
parent ee0d2866c8
commit e69319b5a2
No known key found for this signature in database
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tests/integration/nodeprocess.nim
View File

@ -137,10 +137,19 @@ method stop*(
error = e.msg
writeStackTrace()
finally:
trace "closing node process' streams"
await node.process.closeWait()
node.process = nil
trace "node process' streams closed"
proc closeProcessStreams() {.async: (raises: []).} =
trace "closing node process' streams"
await node.process.closeWait()
node.process = nil
trace "node process' streams closed"
# windows will hang waiting to close process streams, so we can asyncspawn
# in the hopes that it will eventually close them without hanging the
# process
when defined(windows):
asyncSpawn closeProcessStreams()
else:
await closeProcessStreams()
proc waitUntilOutput*(
node: NodeProcess, output: string