logos-storage/logos-storage-nim
1
0
Fork 0
mirror of https://github.com/logos-storage/logos-storage-nim.git synced 2026-01-07 07:53:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move test assertions at end of start so that test.status can be set after timeout

Browse Source
This commit is contained in:
Eric 2025-03-18 15:48:29 +11:00
parent f3997dd95e
commit c22cc10d48
No known key found for this signature in database
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/integration/testmanager.nim
View File

@ -421,7 +421,7 @@ proc teardownTest(
if test.process.running |? false:
try:
output.exitCode =
some (await noCancel test.process.terminateAndWaitForExit(500.millis))
some (await noCancel test.process.terminateAndWaitForExit(1.seconds))
trace "Test process terminated", exitCode = output.exitCode
except AsyncProcessError, AsyncProcessTimeoutError:
let e = getCurrentException()
@ -556,12 +556,6 @@ proc start(test: IntegrationTest) {.async: (raises: []).} =
# `untilTimeout` exceptions are handled in `run`
await test.teardown(hardhat, outputReader, errorReader)
# doesn't raise CancelledError, so noCancel not needed
doAssert test.status != IntegrationTestStatus.New and
test.status != IntegrationTestStatus.Running,
"Integration test is in the wrong state!"
doAssert test.timeEnd.isSome, "Integration test end time not set!"
doAssert (test.output.isOk and output =? test.output and output != nil) or
test.output.isErr, "Integration test output not set!"
output.exitCode =
try:
@ -628,6 +622,10 @@ proc run(test: IntegrationTest) {.async: (raises: []).} =
name = test.config.name
duration = test.duration
doAssert test.timeEnd.isSome, "Integration test end time not set!"
doAssert (test.output.isOk and output =? test.output and output != nil) or
test.output.isErr, "Integration test output not set!"
case test.status
of IntegrationTestStatus.New:
raiseAssert "Test has completed, but is in the New state"