Increase gas estimates (#1192)

* update nim-ethers to version 2.0.0

To allow for gas estimation of contract calls

* contracts: add 10% extra gas to contract calls

These calls could otherwise run out of gas because
the on-chain state may have changed between the time
of the estimate and the time of processing the
transaction.

codex/contracts/config.nim

@@ -1,5 +1,5 @@
 import pkg/contractabi
-import pkg/ethers/fields
+import pkg/ethers/contracts/fields
 import pkg/questionable/results
 
 export contractabi

codex/contracts/market.nim

@@ -257,8 +257,17 @@ method fillSlot(
 
     try:
       await market.approveFunds(collateral)
+
+      # Add 10% to gas estimate to deal with different evm code flow when we
+      # happen to be the last one to fill a slot in this request
+      trace "estimating gas for fillSlot"
+      let gas = await market.contract.estimateGas.fillSlot(requestId, slotIndex, proof)
+      let overrides = TransactionOverrides(gasLimit: some (gas * 110) div 100)
+
       trace "calling fillSlot on contract"
-      discard await market.contract.fillSlot(requestId, slotIndex, proof).confirm(1)
+      discard await market.contract
+      .fillSlot(requestId, slotIndex, proof, overrides)
+      .confirm(1)
       trace "fillSlot transaction completed"
     except Marketplace_SlotNotFree as parent:
       raise newException(
@@ -276,15 +285,30 @@ method freeSlot*(
         # If --reward-recipient specified, use it as the reward recipient, and use
         # the SP's address as the collateral recipient
         let collateralRecipient = await market.getSigner()
+
+        # Add 10% to gas estimate to deal with different evm code flow when we
+        # happen to be the one to make the request fail
+        let gas = await market.contract.estimateGas.freeSlot(
+          slotId, rewardRecipient, collateralRecipient
+        )
+        let overrides = TransactionOverrides(gasLimit: some (gas * 110) div 100)
+
         freeSlot = market.contract.freeSlot(
           slotId,
           rewardRecipient, # --reward-recipient
-          collateralRecipient,
-        ) # SP's address
+          collateralRecipient, # SP's address
+          overrides,
+        )
       else:
         # Otherwise, use the SP's address as both the reward and collateral
         # recipient (the contract will use msg.sender for both)
-        freeSlot = market.contract.freeSlot(slotId)
+
+        # Add 10% to gas estimate to deal with different evm code flow when we
+        # happen to be the one to make the request fail
+        let gas = await market.contract.estimateGas.freeSlot(slotId)
+        let overrides = TransactionOverrides(gasLimit: some (gas * 110) div 100)
+
+        freeSlot = market.contract.freeSlot(slotId, overrides)
 
       discard await freeSlot.confirm(1)
     except Marketplace_SlotIsFree as parent:
@@ -331,7 +355,12 @@ method markProofAsMissing*(
     market: OnChainMarket, id: SlotId, period: Period
 ) {.async: (raises: [CancelledError, MarketError]).} =
   convertEthersError("Failed to mark proof as missing"):
-    discard await market.contract.markProofAsMissing(id, period).confirm(1)
+    # Add 10% to gas estimate to deal with different evm code flow when we
+    # happen to be the one to make the request fail
+    let gas = await market.contract.estimateGas.markProofAsMissing(id, period)
+    let overrides = TransactionOverrides(gasLimit: some (gas * 110) div 100)
+
+    discard await market.contract.markProofAsMissing(id, period, overrides).confirm(1)
 
 method canProofBeMarkedAsMissing*(
     market: OnChainMarket, id: SlotId, period: Period
@@ -351,14 +380,13 @@ method reserveSlot*(
 ) {.async: (raises: [CancelledError, MarketError]).} =
   convertEthersError("Failed to reserve slot"):
     try:
-      discard await market.contract
-      .reserveSlot(
-        requestId,
-        slotIndex,
-        # reserveSlot runs out of gas for unknown reason, but 100k gas covers it
-        TransactionOverrides(gasLimit: some 100000.u256),
-      )
-      .confirm(1)
+      # Add 10% to gas estimate to deal with different evm code flow when we
+      # happen to be the last one that is allowed to reserve the slot
+      let gas = await market.contract.estimateGas.reserveSlot(requestId, slotIndex)
+      let overrides = TransactionOverrides(gasLimit: some (gas * 110) div 100)
+
+      discard
+        await market.contract.reserveSlot(requestId, slotIndex, overrides).confirm(1)
     except SlotReservations_ReservationNotAllowed:
       raise newException(
         SlotReservationNotAllowedError,

codex/contracts/proofs.nim

@@ -1,6 +1,6 @@
 import pkg/stint
 import pkg/contractabi
-import pkg/ethers/fields
+import pkg/ethers/contracts/fields
 
 type
   Groth16Proof* = object

codex/contracts/requests.nim

@@ -3,13 +3,12 @@ import std/sequtils
 import std/typetraits
 import pkg/contractabi
 import pkg/nimcrypto
-import pkg/ethers/fields
+import pkg/ethers/contracts/fields
 import pkg/questionable/results
 import pkg/stew/byteutils
 import pkg/libp2p/[cid, multicodec]
 import ../logutils
 import ../utils/json
-import ../clock
 from ../errors import mapFailure
 
 export contractabi

vendor/nim-ethers

@@ -1 +1 @@
-Subproject commit 5d07b5dbcf584b020c732e84cc8b7229ab3e1083
+Subproject commit bbced4673316763c6ef931b4d0a08069cde2474c