From 6a454490b1ee3f2ff4210be53379c6afcacaa137 Mon Sep 17 00:00:00 2001
From: Arnaud <arnaud@status.im>
Date: Mon, 25 May 2026 17:02:32 +0400
Subject: [PATCH] Cleanup

---
 tests/integration/storageclient.nim | 9 ---------
 tests/storage/helpers/nodeutils.nim | 3 +--
 tests/storage/testdiscovery.nim     | 5 ++---
 tests/storage/testnat.nim           | 2 +-
 4 files changed, 4 insertions(+), 15 deletions(-)

diff --git a/tests/integration/storageclient.nim b/tests/integration/storageclient.nim
index e1bf04a8..dc852533 100644
--- a/tests/integration/storageclient.nim
+++ b/tests/integration/storageclient.nim
@@ -262,15 +262,6 @@ proc hasBlockRaw*(
   let url = client.baseurl & "/data/" & cid & "/exists"
   return client.get(url)
 
-proc connectPeer*(
-    client: StorageClient, peerId: string, addrs: seq[string]
-): Future[void] {.async: (raises: [CancelledError, HttpError]).} =
-  var url = client.baseurl & "/connect/" & peerId
-  if addrs.len > 0:
-    url &= "?" & addrs.mapIt("addrs=" & it).join("&")
-  let response = await client.get(url)
-  assert response.status == 200
-
 proc natRelayRunning*(
     client: StorageClient
 ): Future[?!bool] {.async: (raises: [CancelledError, HttpError]).} =
diff --git a/tests/storage/helpers/nodeutils.nim b/tests/storage/helpers/nodeutils.nim
index 108635a0..f34daa21 100644
--- a/tests/storage/helpers/nodeutils.nim
+++ b/tests/storage/helpers/nodeutils.nim
@@ -227,8 +227,7 @@ proc generateNodes*(
           blockDiscovery.updateRecordsAndSpr(
             switch.peerInfo.addrs, udpPort = bindPort.Port
           )
-          if blockDiscovery.getSpr().isSome:
-            bootstrapNodes.add !blockDiscovery.getSpr()
+          bootstrapNodes.add blockDiscovery.getSpr()
 
         fullNode
       else:
diff --git a/tests/storage/testdiscovery.nim b/tests/storage/testdiscovery.nim
index 863f40a6..bba63d64 100644
--- a/tests/storage/testdiscovery.nim
+++ b/tests/storage/testdiscovery.nim
@@ -1,4 +1,4 @@
-import std/[net, options, sequtils]
+import std/[net, sequtils]
 import pkg/libp2p/[multiaddress, routing_record]
 
 import ../asynctest
@@ -27,8 +27,7 @@ suite "Discovery - SPR record logic":
     disc.updateRecordsAndSpr(@[directAddr], udpPort)
 
     let spr = disc.getSpr()
-    check spr.isSome
-    let addrs = spr.get.data.addresses.mapIt($it.address)
+    let addrs = spr.data.addresses.mapIt($it.address)
     check addrs.anyIt(it.contains("/tcp/"))
     check addrs.anyIt(it.contains("/udp/"))
 
diff --git a/tests/storage/testnat.nim b/tests/storage/testnat.nim
index e4ac92d3..ef5599e1 100644
--- a/tests/storage/testnat.nim
+++ b/tests/storage/testnat.nim
@@ -112,7 +112,7 @@ asyncchecksuite "NAT - handleNatStatus":
 asyncchecksuite "NAT - Hole punching":
   test "setupHolePunching mounts the dcutr protocol on the switch":
     let sw = newStandardSwitch()
-    setupHolePunching(sw)
+    discard setupHolePunching(sw)
     check sw.ms.handlers.anyIt(dcutrCore.DcutrCodec in it.protos)
 
   test "holePunchIfRelayed returns early when the peer has no connections":