logos-storage/logos-storage-nim
1
0
Fork 0
mirror of https://github.com/logos-storage/logos-storage-nim.git synced 2026-01-25 00:33:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Review by Dmitriy: Remember peerWants only if we don't have them.

Browse Source
This commit is contained in:
benbierens 2024-12-20 09:10:30 +01:00
parent 55dbcbe459
commit 23c0f30977
No known key found for this signature in database
GPG Key ID: 877D2C2E09A22F3A
1 changed files with 17 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
codex/blockexchange/engine/engine.nim
View File

@ -409,16 +409,6 @@ proc wantListHandler*(
# Update peerCtx
if idx < 0: # new entry
if not e.cancel:
peerCtx.peerWants.add(e)
# Important TODO! (See https://github.com/codex-storage/nim-codex/pull/1019#issuecomment-2525089803 )
# The if type==WantHave (below) is NOT nested behind the if not cancel (above) on purpose!
# This means we send presence-lists in response to cancel messages.
# Not doing so will degrade the performance by more than an order of magnitude.
# TODO: Investigate WHY the presence list has such a performance impact.
# (Sending a presence-list in response to a cancel is not according to spec and should be removed
# once the performance impact mystery is understood and solved.)
if e.wantType == WantType.WantHave:
# Respond to wantHaves immediately.
let
@ -427,19 +417,30 @@ proc wantListHandler*(
b.pricing.get(Pricing(price: 0.u256))
.price.toBytesBE)
if not have and e.sendDontHave:
presence.add(
BlockPresence(
address: e.address,
`type`: BlockPresenceType.DontHave,
price: price))
if not have and not e.cancel:
# Remember the want only if we don't have it and it's not a cancel.
peerCtx.peerWants.add(e)
if e.sendDontHave:
presence.add(
BlockPresence(
address: e.address,
`type`: BlockPresenceType.DontHave,
price: price))
elif have:
# Important todo: This presence can be added in response to a cancel message.
# This is ignored by the receiving peer. But not doing so degrades performance.
# See: https://github.com/codex-storage/nim-codex/pull/1019#issuecomment-2525089803
# See: https://hackmd.io/40xdtOBbR4GAKp-JWu-IlA
presence.add(
BlockPresence(
address: e.address,
`type`: BlockPresenceType.Have,
price: price))
elif e.wantType == WantType.WantBlock and not e.cancel:
# cancels are always of type wantHave, but just in case
peerCtx.peerWants.add(e)
else: # update existing entry
# peer doesn't want this block anymore
if e.cancel: