From 04327a3986823470b805d653ead8ff05584d1b59 Mon Sep 17 00:00:00 2001
From: Eric <5089238+emizzle@users.noreply.github.com>
Date: Thu, 20 Feb 2025 16:52:51 +1100
Subject: [PATCH] chore(integration): simplify block expiration integration
 test (#1100)

* chore(integration): simplify block expiration integration test

* clean up

* fix after rebase
---
 tests/integration/codexconfig.nim         |  48 ++++++++++
 tests/integration/multinodes.nim          |   1 +
 tests/integration/testblockexpiration.nim | 109 +++++++---------------
 3 files changed, 84 insertions(+), 74 deletions(-)

diff --git a/tests/integration/codexconfig.nim b/tests/integration/codexconfig.nim
index 41d7109c..138ae274 100644
--- a/tests/integration/codexconfig.nim
+++ b/tests/integration/codexconfig.nim
@@ -200,6 +200,54 @@ proc withLogLevel*(
     config.addCliOption("--log-level", $level)
   return startConfig
 
+proc withBlockTtl*(
+    self: CodexConfig, ttl: int
+): CodexConfig {.raises: [CodexConfigError].} =
+  var config = self
+  config.addCliOption("--block-ttl", $ttl)
+  return config
+
+proc withBlockTtl*(
+    self: CodexConfigs, idx: int, ttl: int
+): CodexConfigs {.raises: [CodexConfigError].} =
+  self.checkBounds idx
+
+  var startConfig = self
+  startConfig.configs[idx].addCliOption("--block-ttl", $ttl)
+  return startConfig
+
+proc withBlockTtl*(
+    self: CodexConfigs, ttl: int
+): CodexConfigs {.raises: [CodexConfigError].} =
+  var startConfig = self
+  for config in startConfig.configs.mitems:
+    config.addCliOption("--block-ttl", $ttl)
+  return startConfig
+
+proc withBlockMaintenanceInterval*(
+    self: CodexConfig, interval: int
+): CodexConfig {.raises: [CodexConfigError].} =
+  var config = self
+  config.addCliOption("--block-mi", $interval)
+  return config
+
+proc withBlockMaintenanceInterval*(
+    self: CodexConfigs, idx: int, interval: int
+): CodexConfigs {.raises: [CodexConfigError].} =
+  self.checkBounds idx
+
+  var startConfig = self
+  startConfig.configs[idx].addCliOption("--block-mi", $interval)
+  return startConfig
+
+proc withBlockMaintenanceInterval*(
+    self: CodexConfigs, interval: int
+): CodexConfigs {.raises: [CodexConfigError].} =
+  var startConfig = self
+  for config in startConfig.configs.mitems:
+    config.addCliOption("--block-mi", $interval)
+  return startConfig
+
 proc withSimulateProofFailures*(
     self: CodexConfigs, idx: int, failEveryNProofs: int
 ): CodexConfigs {.raises: [CodexConfigError].} =
diff --git a/tests/integration/multinodes.nim b/tests/integration/multinodes.nim
index ae9a38ab..bade6899 100644
--- a/tests/integration/multinodes.nim
+++ b/tests/integration/multinodes.nim
@@ -22,6 +22,7 @@ export hardhatprocess
 export codexprocess
 export hardhatconfig
 export codexconfig
+export nodeconfigs
 
 type
   RunningNode* = ref object
diff --git a/tests/integration/testblockexpiration.nim b/tests/integration/testblockexpiration.nim
index e3fad75c..7e742c2a 100644
--- a/tests/integration/testblockexpiration.nim
+++ b/tests/integration/testblockexpiration.nim
@@ -1,89 +1,50 @@
-import std/os
-import std/httpclient
-import std/strutils
-from std/net import TimeoutError
+import ../examples
+import ./multinodes
 
-import pkg/chronos
-import ../ethertest
-import ./codexprocess
-import ./nodeprocess
-
-ethersuite "Node block expiration tests":
-  var node: CodexProcess
-  var baseurl: string
-
-  let dataDir = getTempDir() / "Codex1"
-  let content = "test file content"
+multinodesuite "Node block expiration tests":
+  var content: seq[byte]
 
   setup:
-    baseurl = "http://localhost:8080/api/codex/v1"
+    content = await RandomChunker.example(blocks = 8)
 
-  teardown:
-    await node.stop()
+  test "node retains not-expired file",
+    NodeConfigs(
+      clients: CodexConfigs
+        .init(nodes = 1)
+        .withBlockTtl(0, 10)
+        .withBlockMaintenanceInterval(0, 1).some,
+      providers: CodexConfigs.none,
+    ):
+    let client = clients()[0]
+    let clientApi = client.client
 
-    dataDir.removeDir()
-
-  proc startTestNode(blockTtlSeconds: int) {.async.} =
-    node = await CodexProcess.startNode(
-      @[
-        "--api-port=8080",
-        "--data-dir=" & dataDir,
-        "--nat=none",
-        "--listen-addrs=/ip4/127.0.0.1/tcp/0",
-        "--disc-port=8090",
-        "--block-ttl=" & $blockTtlSeconds,
-        "--block-mi=1",
-        "--block-mn=10",
-      ],
-      false,
-      "cli-test-node",
-    )
-    await node.waitUntilStarted()
-
-  proc uploadTestFile(): string =
-    let client = newHttpClient()
-    let uploadUrl = baseurl & "/data"
-    let uploadResponse = client.post(uploadUrl, content)
-    check uploadResponse.status == "200 OK"
-    client.close()
-    uploadResponse.body
-
-  proc downloadTestFile(contentId: string, local = false): Response =
-    let client = newHttpClient(timeout = 3000)
-    let downloadUrl =
-      baseurl & "/data/" & contentId & (if local: "" else: "/network/stream")
-
-    let content = client.get(downloadUrl)
-    client.close()
-    content
-
-  proc hasFile(contentId: string): bool =
-    let client = newHttpClient(timeout = 3000)
-    let dataLocalUrl = baseurl & "/data/" & contentId
-    let content = client.get(dataLocalUrl)
-    client.close()
-    content.code == Http200
-
-  test "node retains not-expired file":
-    await startTestNode(blockTtlSeconds = 10)
-
-    let contentId = uploadTestFile()
+    let contentId = clientApi.upload(content).get
 
     await sleepAsync(2.seconds)
 
-    let response = downloadTestFile(contentId, local = true)
+    let download = clientApi.download(contentId, local = true)
+
     check:
-      hasFile(contentId)
-      response.status == "200 OK"
-      response.body == content
+      download.isOk
+      download.get == string.fromBytes(content)
 
-  test "node deletes expired file":
-    await startTestNode(blockTtlSeconds = 1)
+  test "node deletes expired file",
+    NodeConfigs(
+      clients: CodexConfigs
+        .init(nodes = 1)
+        .withBlockTtl(0, 1)
+        .withBlockMaintenanceInterval(0, 1).some,
+      providers: CodexConfigs.none,
+    ):
+    let client = clients()[0]
+    let clientApi = client.client
 
-    let contentId = uploadTestFile()
+    let contentId = clientApi.upload(content).get
 
     await sleepAsync(3.seconds)
 
+    let download = clientApi.download(contentId, local = true)
+
     check:
-      not hasFile(contentId)
-      downloadTestFile(contentId, local = true).code == Http404
+      download.isFailure
+      download.error.msg == "404 Not Found"