From d0bed64c686d311d63042777f6818ca975a4bfff Mon Sep 17 00:00:00 2001 From: benbierens Date: Tue, 7 Nov 2023 09:25:51 +0100 Subject: [PATCH] Disables resource limits --- Framework/KubernetesWorkflow/ContainerRecipeFactory.cs | 10 ++++++---- ProjectPlugins/CodexPlugin/CodexContainerRecipe.cs | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/Framework/KubernetesWorkflow/ContainerRecipeFactory.cs b/Framework/KubernetesWorkflow/ContainerRecipeFactory.cs index 6e50a1bb..f0d4ed97 100644 --- a/Framework/KubernetesWorkflow/ContainerRecipeFactory.cs +++ b/Framework/KubernetesWorkflow/ContainerRecipeFactory.cs @@ -115,10 +115,12 @@ namespace KubernetesWorkflow SetResourcesRequest(new ContainerResourceSet(milliCPUs, memory)); } - protected void SetResourceLimits(int milliCPUs, ByteSize memory) - { - SetResourceLimits(new ContainerResourceSet(milliCPUs, memory)); - } + // Disabled following a possible bug in the k8s cluster that will throttle containers much more than is + // called for if they have resource limits defined. + //protected void SetResourceLimits(int milliCPUs, ByteSize memory) + //{ + // SetResourceLimits(new ContainerResourceSet(milliCPUs, memory)); + //} protected void SetResourcesRequest(ContainerResourceSet requests) { diff --git a/ProjectPlugins/CodexPlugin/CodexContainerRecipe.cs b/ProjectPlugins/CodexPlugin/CodexContainerRecipe.cs index 867b9bf2..2804564b 100644 --- a/ProjectPlugins/CodexPlugin/CodexContainerRecipe.cs +++ b/ProjectPlugins/CodexPlugin/CodexContainerRecipe.cs @@ -25,7 +25,7 @@ namespace CodexPlugin protected override void Initialize(StartupConfig startupConfig) { SetResourcesRequest(milliCPUs: 100, memory: 100.MB()); - SetResourceLimits(milliCPUs: 4000, memory: 12.GB()); + //SetResourceLimits(milliCPUs: 4000, memory: 12.GB()); var config = startupConfig.Get();