From c98cf1ffc49109f41ee7b6a3b2d00c5bfef2f5b4 Mon Sep 17 00:00:00 2001 From: ThatBen Date: Thu, 5 Jun 2025 15:27:06 +0200 Subject: [PATCH] fixes naming for parameterised fixtures --- Framework/KubernetesWorkflow/K8sNameUtils.cs | 4 +++- Tests/DistTestCore/NameUtils.cs | 9 +++++---- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/Framework/KubernetesWorkflow/K8sNameUtils.cs b/Framework/KubernetesWorkflow/K8sNameUtils.cs index 2c9b1e52..5be69f7f 100644 --- a/Framework/KubernetesWorkflow/K8sNameUtils.cs +++ b/Framework/KubernetesWorkflow/K8sNameUtils.cs @@ -22,7 +22,9 @@ .Replace("\\", "-") .Replace("[", "-") .Replace("]", "-") - .Replace(",", "-"); + .Replace(",", "-") + .Replace("(", "-") + .Replace(")", "-"); if (result.Length > maxLength) result = result.Substring(0, maxLength); result = result.Trim('-'); diff --git a/Tests/DistTestCore/NameUtils.cs b/Tests/DistTestCore/NameUtils.cs index 44919d51..c742ceec 100644 --- a/Tests/DistTestCore/NameUtils.cs +++ b/Tests/DistTestCore/NameUtils.cs @@ -28,10 +28,11 @@ namespace DistTestCore public static string GetRawFixtureName() { var test = TestContext.CurrentContext.Test; - if (test.ClassName!.Contains("AdhocContext")) return "none"; - var className = test.ClassName!.Substring(test.ClassName.LastIndexOf('.') + 1); - className += FormatArguments(test); - return className.Replace('.', '-'); + var fullName = test.FullName; + if (fullName.Contains("AdhocContext")) return "none"; + var name = fullName.Substring(0, fullName.LastIndexOf('.')); + name += FormatArguments(test); + return name.Replace('.', '-').Replace(',', '-'); } public static string GetCategoryName()