logos-storage/logos-storage-nim-cs-dist-tests
1
0
Fork 0
mirror of https://github.com/logos-storage/logos-storage-nim-cs-dist-tests.git synced 2026-01-05 23:13:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for exceptionally long error messages in admin channel on checkCID fail

Browse Source
This commit is contained in:
Ben 2025-04-09 14:39:35 +02:00
parent 6368577d79
commit 89f1f74ffa
No known key found for this signature in database
GPG Key ID: 0F16E812E736C24B
2 changed files with 32 additions and 51 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
Tools/BiblioTech/CodexCidChecker.cs
View File

@ -33,7 +33,7 @@ namespace BiblioTech
{
if (string.IsNullOrEmpty(config.CodexEndpoint))
{
return new CheckResponse(false, "Codex CID checker is not (yet) available.", "");
return new CheckResponse(false, "Codex CID checker is not (yet) available.");
}
try
@ -41,14 +41,10 @@ namespace BiblioTech
checkMutex.WaitOne();
var codex = GetCodex();
var nodeCheck = CheckCodex(codex);
if (!nodeCheck) return new CheckResponse(false, "Codex node is not available. Cannot perform check.", $"Codex node at '{config.CodexEndpoint}' did not respond correctly to debug/info.");
if (!nodeCheck) return new CheckResponse(false, "Codex node is not available. Cannot perform check.");
return PerformCheck(codex, cid);
}
catch (Exception ex)
{
return new CheckResponse(false, "Internal server error", ex.ToString());
}
finally
{
checkMutex.ReleaseMutex();
@ -62,9 +58,9 @@ namespace BiblioTech
var manifest = codex.DownloadManifestOnly(new ContentId(cid));
return SuccessMessage(manifest);
}
catch (Exception ex)
catch
{
return UnexpectedException(ex);
return FailedMessage();
}
}
@ -74,58 +70,27 @@ namespace BiblioTech
{
return FormatResponse(
success: true,
title: $"Success: '{content.Cid}'",
error: "",
title: $"Success",
$"cid: '{content.Cid}'",
$"size: {content.Manifest.OriginalBytes} bytes",
$"blockSize: {content.Manifest.BlockSize} bytes",
$"protected: {content.Manifest.Protected}"
);
}
private CheckResponse UnexpectedException(Exception ex)
private CheckResponse FailedMessage()
{
return FormatResponse(
success: false,
title: "Unexpected error",
error: ex.ToString(),
content: "Details will be sent to the bot-admin channel."
);
}
var msg = "Could not download content.";
private CheckResponse UnexpectedReturnCode(string response)
{
var msg = "Unexpected return code. Response: " + response;
return FormatResponse(
success: false,
title: "Unexpected return code",
error: msg,
content: msg
);
}
private CheckResponse FailedToFetch(string response)
{
var msg = "Failed to download content. Response: " + response;
return FormatResponse(
success: false,
title: "Could not download content",
error: msg,
title: "Failed",
msg,
$"Connection trouble? See 'https://docs.codex.storage/learn/troubleshoot'"
);
}
private CheckResponse CidFormatInvalid(string response)
{
return FormatResponse(
success: false,
title: "Invalid format",
error: "",
content: "Provided CID is not formatted correctly."
);
}
private CheckResponse FormatResponse(bool success, string title, string error, params string[] content)
private CheckResponse FormatResponse(bool success, string title, params string[] content)
{
var msg = string.Join(nl,
new string[]
@ -140,7 +105,7 @@ namespace BiblioTech
})
) + nl + nl;
return new CheckResponse(success, msg, error);
return new CheckResponse(success, msg);
}
#endregion
@ -190,15 +155,13 @@ namespace BiblioTech
public class CheckResponse
{
public CheckResponse(bool success, string message, string error)
public CheckResponse(bool success, string message)
{
Success = success;
Message = message;
Error = error;
}
public bool Success { get; }
public string Message { get; }
public string Error { get; }
}
}

22
Tools/BiblioTech/Commands/CheckCidCommand.cs
View File

@ -1,5 +1,6 @@
using BiblioTech.Options;
using Discord;
using Discord.WebSocket;
namespace BiblioTech.Commands
{
@ -33,18 +34,35 @@ namespace BiblioTech.Commands
return;
}
var response = checker.PerformCheck(cid);
await Program.AdminChecker.SendInAdminChannel($"User {Mention(user)} used '/{Name}' for cid '{cid}'. Lookup-success: {response.Success}. Message: '{response.Message}' Error: '{response.Error}'");
try
{
await PerformCheck(context, user, cid);
}
catch (Exception ex)
{
await RespondeWithError(context, ex);
}
}
private async Task PerformCheck(CommandContext context, SocketUser user, string cid)
{
var response = checker.PerformCheck(cid);
if (response.Success)
{
await CheckAltruisticRole(context, user, cid, response.Message);
return;
}
await Program.AdminChecker.SendInAdminChannel($"User {Mention(user)} used '/{Name}' for cid '{cid}'. Lookup-success: {response.Success}. Message: '{response.Message}'");
await context.Followup(response.Message);
}
private async Task RespondeWithError(CommandContext context, Exception ex)
{
await Program.AdminChecker.SendInAdminChannel("Exception during CheckCidCommand: " + ex);
await context.Followup("I'm sorry to report something has gone wrong in an unexpected way. Error details are already posted in the admin channel.");
}
private async Task CheckAltruisticRole(CommandContext context, IUser user, string cid, string responseMessage)
{
if (cidStorage.TryAddCid(cid, user.Id))