From cd36306b12e2ec77d54b8fe7cd52e983e27b6064 Mon Sep 17 00:00:00 2001 From: Richard Ramos Date: Fri, 25 Oct 2024 12:01:33 -0400 Subject: [PATCH] fix: include storenodes without missing messages in metrics --- cmd/storemsgcounter/execute.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/storemsgcounter/execute.go b/cmd/storemsgcounter/execute.go index 63eaaca..fbf0dbf 100644 --- a/cmd/storemsgcounter/execute.go +++ b/cmd/storemsgcounter/execute.go @@ -449,8 +449,8 @@ func (app *Application) countMissingMessages(storenodes []peer.ID) error { if err != nil { return err } - for storenode, cnt := range results { - app.metrics.RecordMissingMessagesLastHour(storenode, cnt) + for _, storenodeID := range storenodes { + app.metrics.RecordMissingMessagesLastHour(storenodeID, results[storenodeID]) } // not including last two hours in now to let sync work @@ -461,8 +461,8 @@ func (app *Application) countMissingMessages(storenodes []peer.ID) error { if err != nil { return err } - for storenode, cnt := range results { - app.metrics.RecordMissingMessagesLastDay(storenode, cnt) + for _, storenodeID := range storenodes { + app.metrics.RecordMissingMessagesLastDay(storenodeID, results[storenodeID]) } // Count messages in last week (not including last two hours)