From aeddb7f9e7a640ec522463a15cb50fe9cd508b1a Mon Sep 17 00:00:00 2001 From: Fabiana Cecin Date: Wed, 4 Feb 2026 08:28:57 -0300 Subject: [PATCH] Remove dead IDL code, fix sync subscr error text, fix wordslist --- .wordlist.txt | 5 +---- standards/application/waku-api.md | 9 +-------- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/.wordlist.txt b/.wordlist.txt index c22e798..3d89df4 100644 --- a/.wordlist.txt +++ b/.wordlist.txt @@ -95,10 +95,7 @@ rpc SHARDING sharding subnets -SubscribeAction -SubscriptionErrorEvent -subscriptionEvents -SubscriptionEvents +SubscriptionError TBD tcp TCP diff --git a/standards/application/waku-api.md b/standards/application/waku-api.md index fa8d93c..fe633ff 100644 --- a/standards/application/waku-api.md +++ b/standards/application/waku-api.md @@ -463,13 +463,6 @@ types: error: type: string description: "Error message describing what went wrong" - - SubscriptionEvents: - type: event_emitter - description: "Event source for subscription-related events." - events: - "subscription:error": - type: SubscriptionErrorEvent ``` #### Subscriptions function definitions @@ -509,7 +502,7 @@ Only messages on subscribed content topics SHOULD be emitted by a `MessageEvents **`error`**: -Only irremediable failures should lead to emitting a `"subscription:error"` for failed subscribe or unsubscribe operations. +Only irremediable failures should lead to synchronously returning a subscription error for failed subscribe or unsubscribe operations. Failure to reach nodes can be omitted, and should be handled via the health events; [P2P-RELIABILITY](/standards/application/p2p-reliability.md) SHOULD handle automated re-subscriptions and redundancy.