From 49acfd772cb4cbb92c85d631d33a2b37c3083b1d Mon Sep 17 00:00:00 2001 From: danisharora099 Date: Tue, 23 Jul 2024 19:39:39 +0530 Subject: [PATCH 1/3] chore: clarifications for node health when disparity in protocol health --- standards/application/req-res-reliability.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/standards/application/req-res-reliability.md b/standards/application/req-res-reliability.md index 1bc393f..3b3a701 100644 --- a/standards/application/req-res-reliability.md +++ b/standards/application/req-res-reliability.md @@ -40,13 +40,14 @@ Node health is a metric meant to determine the connectivity state of a light nod We consider this reliability to be dependent on amount of simultaneous connections to responsive service nodes. Unfortunately the more connections light node establishes - the more bandwidth is consumed. To address this we RECOMMEND following states: -- unhealthy - no connections to service nodes are available regardless of protocol; +- unhealthy: + - no connections to service nodes are available regardless of protocol. - minimally healthy: - - Filter has one service node connection; - - LightPush protocol has one service node connection; + - Filter has one service node connection AND LightPush protocol has one service node connection. - sufficiently healthy: - - Filter has at least 2 connections available to service nodes; - - LightPush has at least 2 connections available to service nodes; + - Filter has at least 2 connections available to service nodes AND LightPush has at least 2 connections available to service nodes. + +If one of the protocols is unhealthy or minimally healthy, while the other is sufficiently healthy - overall node health SHOULD be considered as unhealthy or minimally healthy respectively. ### Peers and connection management From 2d8076e660f210d1508784da63eb0dcbcbf1f6f3 Mon Sep 17 00:00:00 2001 From: danisharora099 Date: Tue, 23 Jul 2024 20:08:38 +0530 Subject: [PATCH 2/3] chore: update formatting --- standards/application/req-res-reliability.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/standards/application/req-res-reliability.md b/standards/application/req-res-reliability.md index 3b3a701..a35cfe7 100644 --- a/standards/application/req-res-reliability.md +++ b/standards/application/req-res-reliability.md @@ -41,11 +41,11 @@ We consider this reliability to be dependent on amount of simultaneous connectio Unfortunately the more connections light node establishes - the more bandwidth is consumed. To address this we RECOMMEND following states: - unhealthy: - - no connections to service nodes are available regardless of protocol. + - no connections to service nodes are available regardless of protocol; - minimally healthy: - - Filter has one service node connection AND LightPush protocol has one service node connection. + - Filter has one service node connection AND LightPush protocol has one service node connection; - sufficiently healthy: - - Filter has at least 2 connections available to service nodes AND LightPush has at least 2 connections available to service nodes. + - Filter has at least 2 connections available to service nodes AND LightPush has at least 2 connections available to service nodes; If one of the protocols is unhealthy or minimally healthy, while the other is sufficiently healthy - overall node health SHOULD be considered as unhealthy or minimally healthy respectively. From f59a4e3cf4c85ff0aa45f902c817b217f81a22e8 Mon Sep 17 00:00:00 2001 From: danisharora099 Date: Tue, 23 Jul 2024 20:10:25 +0530 Subject: [PATCH 3/3] chore: change sentence to use recommendation first --- standards/application/req-res-reliability.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/standards/application/req-res-reliability.md b/standards/application/req-res-reliability.md index a35cfe7..3a10cd2 100644 --- a/standards/application/req-res-reliability.md +++ b/standards/application/req-res-reliability.md @@ -47,7 +47,7 @@ To address this we RECOMMEND following states: - sufficiently healthy: - Filter has at least 2 connections available to service nodes AND LightPush has at least 2 connections available to service nodes; -If one of the protocols is unhealthy or minimally healthy, while the other is sufficiently healthy - overall node health SHOULD be considered as unhealthy or minimally healthy respectively. +Overall node health SHOULD be considered as unhealthy or minimally healthy respectively if one of the protocols is unhealthy or minimally healthy, while the other is sufficiently healthy. ### Peers and connection management