From fde85bfbe77a5c79fd9a68403c674c7a5da387e3 Mon Sep 17 00:00:00 2001 From: SionoiS Date: Wed, 15 Jan 2025 09:57:17 -0500 Subject: [PATCH 1/3] update --- standards/core/store-sync.md | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/standards/core/store-sync.md b/standards/core/store-sync.md index 9b89269..21b7189 100644 --- a/standards/core/store-sync.md +++ b/standards/core/store-sync.md @@ -27,28 +27,17 @@ Various protocols and features that help with message consistency are described ### Store Resume - - This feature allow a node to fill the gap in messages for the period it was last offline. -At startup, a node use the Store protocol to query a random node for +At startup, a node SHOULD use the Store protocol to query a random node for the time interval since it was last online. -Messages returned by the query are then added to the node local archive storage. +Messages returned by the query are then added to the local node storage. It is RECOMMENDED to limit the time interval to a maximum of 6 hours. ### Waku Sync - - Nodes that stay online can still miss messages. -[Waku Sync](https://github.com/waku-org/specs/blob/master/standards/core/sync.md) is the protocol used to find those message hashes by periodically syncing with random nodes. -It is RECOMMENDED to trigger a sync with a random peer every 5 minutes for a time range of the last hour. -After both message hash sets are reconciled, -the Store protocol SHOULD be used to reciprocally query the other node with the message hash differences found. -Messages returned by the query MUST be added to the node local Waku sync and archive storage. - - +[Waku Sync](https://github.com/waku-org/specs/blob/master/standards/core/sync.md) is 2 libp2p protocols used to find those messages by periodically syncing with random nodes. +It is RECOMMENDED to trigger a sync with a random peer that supports the protocols every 5 minutes for a time range of the last hour. ## Copyright From affcda5ee34b57f52c97cac0daa764ced0616587 Mon Sep 17 00:00:00 2001 From: SionoiS Date: Wed, 15 Jan 2025 10:04:19 -0500 Subject: [PATCH 2/3] clarification & fix --- standards/core/store-sync.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/standards/core/store-sync.md b/standards/core/store-sync.md index 21b7189..63a07fe 100644 --- a/standards/core/store-sync.md +++ b/standards/core/store-sync.md @@ -16,7 +16,7 @@ Message propagation in the network is not perfect, even with GossipSub mechanisms to detect missed messages. Nodes can also go offline for various reason outside our control. Store nodes that want to provide a good service must be able to remedy situations like these. -By having store nodes syncronize with each other through various protocols, +By having store nodes synchronize with each other through various protocols, the set of archived messages network wide will be eventually consistent. ## Theory / Semantics @@ -36,7 +36,7 @@ It is RECOMMENDED to limit the time interval to a maximum of 6 hours. ### Waku Sync Nodes that stay online can still miss messages. -[Waku Sync](https://github.com/waku-org/specs/blob/master/standards/core/sync.md) is 2 libp2p protocols used to find those messages by periodically syncing with random nodes. +[Waku Sync](https://github.com/waku-org/specs/blob/master/standards/core/sync.md) is 2 libp2p protocols used to find those messages and mend the differences by periodically syncing with random nodes. It is RECOMMENDED to trigger a sync with a random peer that supports the protocols every 5 minutes for a time range of the last hour. ## Copyright From fbe93d6e596223706f8228f9fd696fdf331fb830 Mon Sep 17 00:00:00 2001 From: Simon-Pierre Vivier Date: Tue, 21 Jan 2025 09:36:44 -0500 Subject: [PATCH 3/3] Update standards/core/store-sync.md Co-authored-by: Hanno Cornelius <68783915+jm-clius@users.noreply.github.com> --- standards/core/store-sync.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/standards/core/store-sync.md b/standards/core/store-sync.md index 63a07fe..892a0a0 100644 --- a/standards/core/store-sync.md +++ b/standards/core/store-sync.md @@ -36,7 +36,8 @@ It is RECOMMENDED to limit the time interval to a maximum of 6 hours. ### Waku Sync Nodes that stay online can still miss messages. -[Waku Sync](https://github.com/waku-org/specs/blob/master/standards/core/sync.md) is 2 libp2p protocols used to find those messages and mend the differences by periodically syncing with random nodes. +[Waku Sync](https://github.com/waku-org/specs/blob/master/standards/core/sync.md) consists of two libp2p protocols, +respectively used to (i) find those messages and (ii) mend the differences by periodically syncing with random nodes. It is RECOMMENDED to trigger a sync with a random peer that supports the protocols every 5 minutes for a time range of the last hour. ## Copyright