chore: remove debugs

sds/sds.go

@@ -216,17 +216,14 @@ func sdsGlobalRetrievalHintProvider(messageId *C.char, hint **C.char, hintLen *C
 	msgId := C.GoString(messageId)
 	Debug("sdsGlobalRetrievalHintProvider called for messageId: %s", msgId)
 	rm, ok := rmRegistry[userData]
-	if ok && rm.callbacks.RetrievalHintProvider != nil {
-		Debug("Found RM and callback, calling provider")
-		hintBytes := rm.callbacks.RetrievalHintProvider(MessageID(msgId))
-		Debug("Provider returned hint of length: %d", len(hintBytes))
-		if len(hintBytes) > 0 {
-			*hint = (*C.char)(C.CBytes(hintBytes))
-			*hintLen = C.size_t(len(hintBytes))
-			Debug("Set hint in C memory: %s", string(hintBytes))
+	if ok {
+		if rm.callbacks.RetrievalHintProvider != nil {
+			hintBytes := rm.callbacks.RetrievalHintProvider(MessageID(msgId))
+			if len(hintBytes) > 0 {
+				*hint = (*C.char)(C.CBytes(hintBytes))
+				*hintLen = C.size_t(len(hintBytes))
+			}
 		}
-	} else {
-		Debug("No RM found or no callback registered")
 	}
 }
 

sds/sds_test.go

@@ -10,7 +10,7 @@ import (
 
 // Test basic creation, cleanup, and reset
 func TestLifecycle(t *testing.T) {
-	rm, err := NewReliabilityManager()
+	rm, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	require.NotNil(t, rm, "Expected ReliabilityManager to be not nil")
 
@@ -22,7 +22,7 @@ func TestLifecycle(t *testing.T) {
 
 // Test wrapping and unwrapping a simple message
 func TestWrapUnwrap(t *testing.T) {
-	rm, err := NewReliabilityManager()
+	rm, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer rm.Cleanup()
 
@@ -45,7 +45,7 @@ func TestWrapUnwrap(t *testing.T) {
 
 // Test dependency handling
 func TestDependencies(t *testing.T) {
-	rm, err := NewReliabilityManager()
+	rm, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer rm.Cleanup()
 
@@ -68,7 +68,7 @@ func TestDependencies(t *testing.T) {
 	require.NoError(t, err)
 
 	// 3. Create a new manager to simulate a different peer receiving msg2 without msg1
-	rm2, err := NewReliabilityManager()
+	rm2, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer rm2.Cleanup()
 
@@ -95,11 +95,11 @@ func TestDependencies(t *testing.T) {
 // Test OnMessageReady callback
 func TestCallback_OnMessageReady(t *testing.T) {
 	// Create sender and receiver RMs
-	senderRm, err := NewReliabilityManager()
+	senderRm, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer senderRm.Cleanup()
 
-	receiverRm, err := NewReliabilityManager()
+	receiverRm, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer receiverRm.Cleanup()
 
@@ -151,11 +151,11 @@ func TestCallback_OnMessageReady(t *testing.T) {
 // Test OnMessageSent callback (via causal history ACK)
 func TestCallback_OnMessageSent(t *testing.T) {
 	// Create two RMs
-	rm1, err := NewReliabilityManager()
+	rm1, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer rm1.Cleanup()
 
-	rm2, err := NewReliabilityManager()
+	rm2, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer rm2.Cleanup()
 
@@ -222,11 +222,11 @@ func TestCallback_OnMessageSent(t *testing.T) {
 // Test OnMissingDependencies callback
 func TestCallback_OnMissingDependencies(t *testing.T) {
 	// Use separate sender/receiver RMs explicitly
-	senderRm, err := NewReliabilityManager()
+	senderRm, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer senderRm.Cleanup()
 
-	receiverRm, err := NewReliabilityManager()
+	receiverRm, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer receiverRm.Cleanup()
 
@@ -301,7 +301,7 @@ func TestCallback_OnMissingDependencies(t *testing.T) {
 
 // Test OnPeriodicSync callback
 func TestCallback_OnPeriodicSync(t *testing.T) {
-	rm, err := NewReliabilityManager()
+	rm, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer rm.Cleanup()
 
@@ -347,11 +347,11 @@ func TestCallback_OnPeriodicSync(t *testing.T) {
 // Combined Test for multiple callbacks
 func TestCallbacks_Combined(t *testing.T) {
 	// Create sender and receiver RMs
-	senderRm, err := NewReliabilityManager()
+	senderRm, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer senderRm.Cleanup()
 
-	receiverRm, err := NewReliabilityManager()
+	receiverRm, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer receiverRm.Cleanup()
 
@@ -445,7 +445,7 @@ func TestCallbacks_Combined(t *testing.T) {
 	require.NoError(t, err)
 
 	// 6. Create Receiver2, register missing deps callback
-	receiverRm2, err := NewReliabilityManager()
+	receiverRm2, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer receiverRm2.Cleanup()
 
@@ -553,7 +553,7 @@ func waitTimeout(wg *sync.WaitGroup, timeout time.Duration, t *testing.T) {
 
 // Test multi-channel functionality - one RM can handle messages from different channels
 func TestMultiChannel_SingleRM(t *testing.T) {
-	rm, err := NewReliabilityManager()
+	rm, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer rm.Cleanup()
 
@@ -600,12 +600,12 @@ func TestMultiChannel_SingleRM(t *testing.T) {
 // Test that callbacks are correctly triggered for multiple channels
 func TestMultiChannelCallbacks(t *testing.T) {
 	// rm1 is the manager we are testing callbacks on
-	rm1, err := NewReliabilityManager()
+	rm1, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer rm1.Cleanup()
 
 	// rm2 simulates another peer
-	rm2, err := NewReliabilityManager()
+	rm2, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer rm2.Cleanup()
 
@@ -687,7 +687,7 @@ func TestMultiChannelCallbacks(t *testing.T) {
 }
 
 func TestRetrievalHints(t *testing.T) {
-	rm, err := NewReliabilityManager()
+	rm, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer rm.Cleanup()
 
@@ -718,7 +718,7 @@ func TestRetrievalHints(t *testing.T) {
 
 	// 4. Unwrap the second message to inspect its causal history
 	// We need a new RM to avoid acknowledging the message
-	rm2, err := NewReliabilityManager()
+	rm2, err := NewReliabilityManager(nil)
 	require.NoError(t, err)
 	defer rm2.Cleanup()