From 47317636414c471e3c7cc7937310b6e2d781983f Mon Sep 17 00:00:00 2001 From: Patitotective Date: Thu, 1 Dec 2022 17:24:54 -0500 Subject: [PATCH] -d:dontFetchRepos and config.nims (#2391) * Check for empty tags * - Added the `-d:dontFetchRepos` flag - Made empty tags an error - Created `config.nims` - Removed empty tags from `packages.json` * Revert "- Added the `-d:dontFetchRepos` flag" This reverts commit 2b653ebcf0b242887e08b95492f2cc1b2bed3a19. * - Made empty tags an error - Removed empty tags from `packages.json` * Revert "- Made empty tags an error" This reverts commit 1d116ae808eb3a4b69449af52feac1fb547bf45e. * - Added the `-d:dontFetchRepos` flag - Created `config.nims` --- config.nims | 1 + package_scanner.nim | 8 +++++--- 2 files changed, 6 insertions(+), 3 deletions(-) create mode 100644 config.nims diff --git a/config.nims b/config.nims new file mode 100644 index 0000000..fc86e83 --- /dev/null +++ b/config.nims @@ -0,0 +1 @@ +--define:ssl diff --git a/package_scanner.nim b/package_scanner.nim index 3953d8e..7fb7eea 100644 --- a/package_scanner.nim +++ b/package_scanner.nim @@ -12,7 +12,7 @@ # * Missing/unknown license # * Insecure git:// url on GitHub # -# Usage: nim r -d:ssl package_scanner.nim +# Usage: nim r [-d:dontFetchRepos] package_scanner.nim # # Copyright 2015 Federico Ceratto # Released under GPLv3 License, see /usr/share/common-licenses/GPL-3 @@ -165,8 +165,10 @@ proc check(): int = elif pkg["license"].str.toLowerAscii notin licenses: echo "E: ", name, " has an unexpected license: ", pkg["license"] inc result - elif pkg.hasKey("web") and not canFetchNimbleRepository(name, pkg["web"]): - echo "W: Failed to fetch source code repo for ", name + elif pkg.hasKey("web"): + when not defined(dontFetchRepos): + if not canFetchNimbleRepository(name, pkg["web"]): + echo "W: Failed to fetch source code repo for ", name elif pkg.hasKey("tags"): var emptyTags = 0 for tag in pkg["tags"]: