logos-messaging/nim-sds
1
0
Fork 0
mirror of https://github.com/logos-messaging/nim-sds.git synced 2026-07-27 18:13:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

enhance validations when deserializing message

Browse Source
This commit is contained in:
Ivan FB 2026-06-11 10:46:29 +02:00
parent 3ef6a55257
commit 7e832a4428
No known key found for this signature in database
GPG Key ID: DF0C67A04C543270
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
sds/protobuf.nim
View File

@ -121,8 +121,17 @@ proc serializeMessage*(msg: SdsMessage): Result[seq[byte], ReliabilityError] =
return err(ReliabilityError.reSerializationError)
proc deserializeMessage*(data: seq[byte]): Result[SdsMessage, ReliabilityError] =
## proto3 has no required fields, so presence is validated by hand. Only the
## identifiers are mandatory: `content`, `bloomFilter` and a zero
## `lamportTimestamp` may legitimately be empty (e.g. periodic sync messages).
try:
return ok(Protobuf.decode(data, SdsMessagePB).fromPB)
let pb = Protobuf.decode(data, SdsMessagePB)
if pb.messageId.len == 0 or pb.channelId.len == 0:
return err(ReliabilityError.reDeserializationError)
for e in pb.causalHistory & pb.repairRequest:
if e.messageId.len == 0:
return err(ReliabilityError.reDeserializationError)
return ok(pb.fromPB)
except CatchableError:
return err(ReliabilityError.reDeserializationError)