logos-messaging/nim-ffi
1
0
Fork 0
mirror of https://github.com/logos-messaging/nim-ffi.git synced 2026-08-05 22:43:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(tests): ignore non-terminal RET_STALE_WARN in testCallback

Browse Source 
The shared result callback treated every code as an answer, so the 5s
stale ping fired by the slow arm+ASan runner during the 50k-ref-alloc
handler woke waitCallback with retCode=3 and let the test tear the
context down while the handler was still running -- which in turn made
destroyFFIContext err and left the event thread firing on a torn-down
signal (the UBSan fireSync null deref). Honour the same contract the
generated C/C++/Rust trampolines now follow: a progress ping is not a
reply. Tests asserting on the pings use staleCallback instead.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Ivan FB 2026-07-14 14:31:42 +02:00
parent 7e7632a8e9
commit 0d1abb4ced
No known key found for this signature in database
GPG Key ID: DF0C67A04C543270
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/unit/test_ffi_context.nim
View File

@ -27,6 +27,12 @@ proc deinitCallbackData(d: var CallbackData) =
proc testCallback(
retCode: cint, msg: ptr cchar, len: csize_t, userData: pointer
) {.cdecl, gcsafe, raises: [].} =
# RET_STALE_WARN is a progress ping, not an answer: a slow handler (or a slow
# CI runner) trips it before the terminal code arrives. Waking `waitCallback`
# here would hand the test a non-terminal retCode and let it tear the context
# down mid-flight. Tests that assert on the pings use `staleCallback`.
if retCode == RET_STALE_WARN:
return
let d = cast[ptr CallbackData](userData)
acquire(d[].lock)
d[].retCode = retCode