From c3ec4be6b4559efa4b6d409d99c8ab6bd4df679f Mon Sep 17 00:00:00 2001 From: Tanya S <120410716+stubbsta@users.noreply.github.com> Date: Mon, 15 Sep 2025 14:03:03 +0200 Subject: [PATCH] Add string revert error event for onlyOwnerOrMinter (#36) * Add string revert for AccountNotMinter error * Add TST initialize argument in WakuRlnV2.t.sol --- test/TestStableToken.sol | 2 +- test/TestStableToken.t.sol | 4 ++-- test/WakuRlnV2.t.sol | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/test/TestStableToken.sol b/test/TestStableToken.sol index 1125ebf..02b3cde 100644 --- a/test/TestStableToken.sol +++ b/test/TestStableToken.sol @@ -31,7 +31,7 @@ contract TestStableToken is event MaxSupplySet(uint256 oldMaxSupply, uint256 newMaxSupply); modifier onlyOwnerOrMinter() { - if (msg.sender != owner() && !isMinter[msg.sender]) revert AccountNotMinter(); + if (msg.sender != owner() && !isMinter[msg.sender]) revert("AccountNotMinter"); _; } diff --git a/test/TestStableToken.t.sol b/test/TestStableToken.t.sol index 7bf8f0b..8954232 100644 --- a/test/TestStableToken.t.sol +++ b/test/TestStableToken.t.sol @@ -117,7 +117,7 @@ contract TestStableTokenTest is Test { uint256 mintAmount = 1000 ether; vm.prank(nonMinter); - vm.expectRevert(abi.encodeWithSelector(AccountNotMinter.selector)); + vm.expectRevert("AccountNotMinter"); token.mint(user1, mintAmount); } @@ -145,7 +145,7 @@ contract TestStableTokenTest is Test { token.removeMinter(user1); vm.prank(user1); - vm.expectRevert(abi.encodeWithSelector(AccountNotMinter.selector)); + vm.expectRevert("AccountNotMinter"); token.mint(user2, mintAmount); } diff --git a/test/WakuRlnV2.t.sol b/test/WakuRlnV2.t.sol index 0cf58b7..ea6414c 100644 --- a/test/WakuRlnV2.t.sol +++ b/test/WakuRlnV2.t.sol @@ -21,7 +21,7 @@ contract MaliciousToken is TestStableToken { bool public failTransferEnabled; function initialize(address _target, bool _failTransferEnabled) public initializer { - super.initialize(); + super.initialize(100_000_000 ether); target = _target; failTransferEnabled = _failTransferEnabled; } @@ -1168,7 +1168,7 @@ contract WakuRlnV2Test is Test { MaliciousToken maliciousToken = MaliciousToken(address(proxy)); // Mint tokens - maliciousToken.mint(address(this), 100_000_000 ether); + maliciousToken.mint(address(this), 100_000 ether); // Compute new calculator before prank address newCalc = address(new DeployPriceCalculator().deploy(address(maliciousToken)));