logos-messaging/logos-messaging-rlnv2-contract
1
0
Fork 0
mirror of https://github.com/logos-messaging/logos-messaging-rlnv2-contract.git synced 2026-05-01 07:53:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

note inconsistency re: holder vs sender vs keeper

Browse Source
This commit is contained in:
Sergei Tikhomirov 2024-09-25 11:40:52 +02:00
parent ad92298a0c
commit 66c5f68d3a
No known key found for this signature in database
GPG Key ID: 6A1F8ED9D6538027
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Membership.sol
View File

@ -177,7 +177,7 @@ abstract contract MembershipUpgradeable is Initializable {
/// @dev Setup a new membership. If there are not enough remaining rate limit to acquire
/// a new membership, it will attempt to erase existing expired memberships
/// and reuse one of their slots
/// @param _sender holder of the membership. Generally `msg.sender` // FIXME: rename to holder?
/// @param _sender holder of the membership. Generally `msg.sender`
/// @param _idCommitment idCommitment
/// @param _rateLimit membership rate limit
/// @param _token Address of the token used to acquire the membership
@ -208,7 +208,7 @@ abstract contract MembershipUpgradeable is Initializable {
(index, indexReused) = _getFreeIndex();
memberships[_idCommitment] = MembershipInfo({
holder: _sender,
holder: _sender, // FIXME: inconsistent with spec (keeper vs holder)
gracePeriodStartTimestamp: block.timestamp + uint256(expirationTerm),
gracePeriodDuration: gracePeriodDuration,
token: _token,