logos-messaging/logos-messaging-rlnv2-contract
1
0
Fork 0
mirror of https://github.com/logos-messaging/logos-messaging-rlnv2-contract.git synced 2026-01-10 01:43:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: more efficient duplicate members check

Browse Source
This commit is contained in:
Richard Ramos 2024-09-23 17:18:54 -04:00
parent df502c78ff
commit 522599c704
No known key found for this signature in database
GPG Key ID: 1CE87DB518195760
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/WakuRlnV2.sol
View File

@ -55,6 +55,11 @@ contract WakuRlnV2 is Initializable, Ownable2StepUpgradeable, UUPSUpgradeable, M
_;
}
modifier noDuplicateMembers(uint256 idCommitment) {
if (members[idCommitment].userMessageLimit != 0) revert DuplicateIdCommitment();
_;
}
constructor() {
_disableInitializers();
}
@ -133,9 +138,14 @@ contract WakuRlnV2 is Initializable, Ownable2StepUpgradeable, UUPSUpgradeable, M
/// @notice Allows a user to register as a member
/// @param idCommitment The idCommitment of the member
/// @param userMessageLimit The message limit of the member
function register(uint256 idCommitment, uint32 userMessageLimit) external onlyValidIdCommitment(idCommitment) {
if (memberExists(idCommitment)) revert DuplicateIdCommitment();
function register(
uint256 idCommitment,
uint32 userMessageLimit
)
external
onlyValidIdCommitment(idCommitment)
noDuplicateMembers(idCommitment)
{
uint32 index;
bool reusedIndex;
(index, reusedIndex) = _acquireMembership(_msgSender(), idCommitment, userMessageLimit, true);
@ -154,9 +164,8 @@ contract WakuRlnV2 is Initializable, Ownable2StepUpgradeable, UUPSUpgradeable, M
)
external
onlyValidIdCommitment(idCommitment)
noDuplicateMembers(idCommitment)
{
if (memberExists(idCommitment)) revert DuplicateIdCommitment();
for (uint256 i = 0; i < membershipsToErase.length; i++) {
uint256 idCommitmentToErase = membershipsToErase[i];
MembershipInfo memory mdetails = members[idCommitmentToErase];