From 5181d2df5e275fe1811edd8e8de49001f811d2d8 Mon Sep 17 00:00:00 2001 From: Sergei Tikhomirov Date: Wed, 25 Sep 2024 15:07:04 +0200 Subject: [PATCH] fix min-max check in membership initializer --- src/Membership.sol | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Membership.sol b/src/Membership.sol index f572c02..2ee84ba 100644 --- a/src/Membership.sol +++ b/src/Membership.sol @@ -134,9 +134,9 @@ abstract contract MembershipUpgradeable is Initializable { internal onlyInitializing { - require(_maxTotalRateLimit >= maxMembershipRateLimit); - require(_maxMembershipRateLimit > minMembershipRateLimit); // FIXME: > or >=? - require(_minMembershipRateLimit > 0); + require(0 < _minMembershipRateLimit); + require(_minMembershipRateLimit <= _maxMembershipRateLimit); // FIXME: < or <=? + require(_maxMembershipRateLimit <= _maxTotalRateLimit); require(_activeStateDuration > 0); // FIXME: also _gracePeriodDuration > 0? priceCalculator = IPriceCalculator(_priceCalculator);