Fix review comment again

This commit is contained in:
Aya Hassan 2026-04-02 17:04:18 +02:00
parent 3ddad013f7
commit 5aed7aca96

View File

@ -310,13 +310,9 @@ class NodeWrapper:
state = _new_cb_state() state = _new_cb_state()
cb = self._make_waiting_cb(state) cb = self._make_waiting_cb(state)
rc = lib.logosdelivery_get_available_node_info_ids( rc = lib.logosdelivery_get_available_node_info_ids(self.ctx, cb, ffi.NULL)
self.ctx,
cb,
ffi.NULL,
)
if rc != 0: if rc != 0:
return Err("call failed") return Err("fail")
wait_result = _wait_cb_raw(state, "get_available_node_info_ids", timeout_s) wait_result = _wait_cb_raw(state, "get_available_node_info_ids", timeout_s)
if wait_result.is_err(): if wait_result.is_err():
@ -324,23 +320,15 @@ class NodeWrapper:
cb_ret, cb_msg = wait_result.ok_value cb_ret, cb_msg = wait_result.ok_value
if cb_ret != 0: if cb_ret != 0:
return Err("callback failed") return Err("fail")
if not cb_msg:
return Err("empty")
text = cb_msg.decode("utf-8").strip() text = cb_msg.decode("utf-8").strip()
if not text.startswith("@[") or not text.endswith("]"): # simple parse
return Err("bad format") inner = text.replace("@[", "").replace("]", "").strip()
inner = text[2:-1].strip()
if not inner:
return Ok([])
items = [item.strip() for item in inner.split(",")]
return Ok(items)
return Ok([] if not inner else [x.strip() for x in inner.split(",")])
def get_node_info(self, node_info_id: str, *, timeout_s: float = 20.0) -> Result[dict, str]: def get_node_info(self, node_info_id: str, *, timeout_s: float = 20.0) -> Result[dict, str]:
state = _new_cb_state() state = _new_cb_state()
cb = self._make_waiting_cb(state) cb = self._make_waiting_cb(state)