mirror of
https://github.com/logos-messaging/logos-messaging-nim.git
synced 2026-05-18 00:09:52 +00:00
* persistency: per-job SQLite-backed storage layer (singleton, brokered)
Adds a backend-neutral CRUD library at waku/persistency/, plus the
nim-brokers dependency swap that enables it.
Architecture (ports-and-adapters):
* Persistency: process-wide singleton, one root directory.
* Job: one tenant, one DB file, one worker thread, one BrokerContext.
* Backend: SQLite via waku/common/databases/db_sqlite. Uniform schema
kv(category BLOB, key BLOB, payload BLOB) PRIMARY KEY (category, key)
WITHOUT ROWID, WAL mode.
* Writes are fire-and-forget via EventBroker(mt) PersistEvent.
* Reads are async via five RequestBroker(mt) shapes (KvGet, KvExists,
KvScan, KvCount, KvDelete). Reads return Result[T, PersistencyError].
* One storage thread per job; tenants isolated by BrokerContext.
Public surface (waku/persistency/persistency.nim):
Persistency.instance(rootDir) / Persistency.instance() / Persistency.reset()
p.openJob(id) / p.closeJob(id) / p.dropJob(id) / p.close()
p.job(id) / p[id] / p.hasJob(id)
Writes (Job form & string-id form, fire-and-forget):
persist / persistPut / persistDelete / persistEncoded
Reads (Job form & string-id form, async Result):
get / exists / scan / scanPrefix / count / deleteAcked
Key & payload encoding (keys.nim, payload.nim):
* encodePart family + variadic key(...) / payload(...) macros +
single-value toKey / toPayload.
* Primitives: string and openArray[byte] are 2-byte BE length + bytes;
int{8..64} are sign-flipped 8-byte BE; uint{16..64} are 8-byte BE;
bool/byte/char are 1 byte; enums are int64(ord(v)).
* Generic encodePart[T: tuple | object] recurses through fields() so
any composite Nim type is encodable without ceremony.
* Stable across Nim/C compiler upgrades: no sizeof, no memcpy, no
cast on pointers, no host-endianness dependency.
* `rawKey(bytes)` + `persistPut(..., openArray[byte])` let callers
bypass the built-in encoder with their own format (CBOR, protobuf...).
Lifecycle:
* Persistency.new is private; Persistency.instance is the only public
constructor. Same rootDir is idempotent; conflicting rootDir is
peInvalidArgument. Persistency.reset for test/restart paths.
* openJob opens-or-creates the per-job SQLite file; an existing file
is reused with its data preserved.
* Teardown integration: Persistency.instance registers a Teardown
MultiRequestBroker provider that closes all jobs and clears the
singleton slot when Waku.stop() issues Teardown.request.
Internal layering:
types.nim pure value types (Key, KeyRange, KvRow, TxOp,
PersistencyError)
keys.nim encodePart primitives + key(...) macro
payload.nim toPayload + payload(...) macro
schema.nim CREATE TABLE + connection pragmas + user_version
backend_sqlite.nim KvBackend, applyOps (single source of write SQL),
getOne/existsOne/deleteOne, scanRange (asc/desc,
half-open ranges, open-ended stop), countRange
backend_comm.nim EventBroker(mt) PersistEvent + 5 RequestBroker(mt)
declarations; encodeErr/decodeErr boundary helpers
backend_thread.nim startStorageThread / stopStorageThread (shared
allocShared0 arg, cstring dbPath, atomic
ready/shutdown flags); per-thread provider
registration
persistency.nim Persistency + Job types, singleton state, public
facade
../requests/lifecycle_requests.nim
Teardown MultiRequestBroker
Tests (69 cases, all passing):
test_keys.nim sort-order invariants (length-prefix strings,
sign-flipped ints, composite tuples, prefix
range)
test_backend.nim round-trip / replace / delete-return-value /
batched atomicity / asc-desc-half-open-open-
ended scans / category isolation / batch
txDelete
test_lifecycle.nim open-or-create rootDir / non-dir collision /
reopen across sessions / idempotent openJob /
two-tenant parallel isolation / closeJob joins
worker / dropJob removes file / acked delete
test_facade.nim put-then-get / atomic batch / scanPrefix
asc/desc / deleteAcked hit-miss /
fire-and-forget delete / two-tenant facade
isolation
test_encoding.nim tuple/named-tuple/object keys, embedded Key,
enum encoding, field-major composite sort,
payload struct encoding, end-to-end struct
round-trip through SQLite
test_string_lookup.nim peJobNotFound semantics / hasJob / subscript /
persistPut+get via id / reads short-circuit /
writes drop+warn / persistEncoded via id /
scan parity Job-ref vs id
test_singleton.nim idempotent same-rootDir / different-rootDir
rejection / no-arg instance lifecycle / reset
retargets / reset idempotence / Teardown.request
end-to-end
Prerequisite delivered in the same series: replace the in-tree broker
implementation with the external nim-brokers package; update all
broker call-sites (waku_filter_v2, waku_relay, waku_rln_relay,
delivery_service, peer_manager, requests/*, factory/*, api tests, etc.)
to the new package API; chat2 made to compile again.
Note: SDS adapter (Phase 5 of the design) is deferred -- nim-sds is
still developed side-by-side and the persistency layer is intentionally
SDS-agnostic.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* persistency: pin nim-brokers by URL+commit (workaround for stale registry)
The bare `brokers >= 2.0.1` form cannot resolve on machines where the
local nimble SAT solver enumerates only the registry-recorded 0.1.0 for
brokers. The nim-lang/packages entry for `brokers` carries no per-tag
metadata (only the URL), so until that registry entry is refreshed the
SAT solver clamps the available-versions list to 0.1.0 and rejects the
>= 2.0.1 constraint -- even though pkgs2 and pkgcache both have v2.0.1
cloned locally.
Pinning by URL+commit bypasses the registry path entirely. Inline
comment in waku.nimble documents the situation and the path back to
the bare form once nim-lang/packages is updated.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* persistency: nph format pass
Run `nph` on all 57 Nim files touched by this PR. Pure formatting:
17 files re-styled, no semantic change. Suite still 69/69.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* Fix build, add local-storage-path config, lazy init of Persistency from Waku start
* fix: fix nix deps
* fixes for nix build, regenerate deps
* reverting accidental dependency changes
* Fixing deps
* Apply suggestions from code review
Co-authored-by: Ivan FB <128452529+Ivansete-status@users.noreply.github.com>
* persistency tests: migrate to suite / asyncTest / await
Match the in-tree test convention (procSuite -> suite, sync test +
waitFor -> asyncTest + await):
- procSuite "X": -> suite "X":
- For tests doing async work: test -> asyncTest, waitFor -> await.
- Poll helpers (proc waitFor(t: Job, ...) in test_lifecycle.nim,
proc waitUntilExists(...) in test_facade.nim and
test_string_lookup.nim) -> Future[bool] {.async.}, internal
`waitFor X` -> `await X`, internal `sleep(N)` ->
`await sleepAsync(chronos.milliseconds(N))`.
- Renamed test_lifecycle.nim's helper proc from `waitFor(t: Job, ...)`
-> `pollExists(t: Job, ...)`; the previous name shadowed
chronos.waitFor in the chronos macro expansion.
- `chronos.milliseconds(N)` explicitly qualified because `std/times`
also exports `milliseconds` (returning TimeInterval, not Duration).
- `check await x` -> `let okN = await x; check okN` to dodge chronos's
"yield in expr not lowered" with await-as-macro-argument.
- `(await x).foo()` -> `let awN = await x; ... awN.foo() ...` for the
same reason.
waku/persistency/persistency.nim: nph also pulled the proc signatures
across multiple lines; restored explicit `Future[void] {.async.}`
return types after the colon (an intermediate nph pass had elided them).
Suite: 71 / 71 OK against the new async write surface.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* use idiomatic valueOr instead of ifs
* Reworked persistency shutdown, remove not necessary teardown mechanism
* Use const for DefaultStoragePath
* format to follow coding guidelines - no use of result and explicit returns - no functional change
---------
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Co-authored-by: Ivan FB <128452529+Ivansete-status@users.noreply.github.com>
185 lines
5.1 KiB
Nim
185 lines
5.1 KiB
Nim
{.used.}
|
|
|
|
import std/[options, os, times]
|
|
import chronos, results
|
|
import testutils/unittests
|
|
import waku/persistency/persistency
|
|
|
|
proc payloadBytes(s: string): seq[byte] =
|
|
result = newSeq[byte](s.len)
|
|
for i, c in s:
|
|
result[i] = byte(c)
|
|
|
|
template str(b: seq[byte]): string =
|
|
var s = newString(b.len)
|
|
for i, x in b:
|
|
s[i] = char(x)
|
|
s
|
|
|
|
proc tmpRoot(label: string): string =
|
|
let p = getTempDir() / ("persistency_lookup_" & label & "_" & $epochTime().int)
|
|
removeDir(p)
|
|
p
|
|
|
|
# Bridge the persist->read race (writes are fire-and-forget in v1).
|
|
proc waitUntilExists(
|
|
p: Persistency, jobId, category: string, k: Key, timeoutMs = 1000
|
|
): Future[bool] {.async.} =
|
|
let deadline = epochTime() + (timeoutMs.float / 1000.0)
|
|
while epochTime() < deadline:
|
|
let r = await p.exists(jobId, category, k)
|
|
if r.isOk and r.get():
|
|
return true
|
|
await sleepAsync(chronos.milliseconds(2))
|
|
return false
|
|
|
|
suite "Persistency string-id lookup":
|
|
test "job(p, id) returns peJobNotFound when not open":
|
|
let root = tmpRoot("notfound")
|
|
defer:
|
|
removeDir(root)
|
|
let p = Persistency.instance(root).get()
|
|
defer:
|
|
Persistency.reset()
|
|
|
|
let r = p.job("nope")
|
|
check r.isErr
|
|
check r.error.kind == peJobNotFound
|
|
|
|
test "job(p, id) returns the Job after openJob":
|
|
let root = tmpRoot("found")
|
|
defer:
|
|
removeDir(root)
|
|
let p = Persistency.instance(root).get()
|
|
defer:
|
|
Persistency.reset()
|
|
|
|
let opened = p.openJob("alpha").get()
|
|
let looked = p.job("alpha").get()
|
|
check looked.id == "alpha"
|
|
check looked == opened # same ref, no need to peek at .context
|
|
|
|
test "hasJob mirrors p.job()":
|
|
let root = tmpRoot("has")
|
|
defer:
|
|
removeDir(root)
|
|
let p = Persistency.instance(root).get()
|
|
defer:
|
|
Persistency.reset()
|
|
|
|
check not p.hasJob("x")
|
|
discard p.openJob("x")
|
|
check p.hasJob("x")
|
|
p.closeJob("x")
|
|
check not p.hasJob("x")
|
|
|
|
test "subscript [] returns the open Job":
|
|
let root = tmpRoot("subscript")
|
|
defer:
|
|
removeDir(root)
|
|
let p = Persistency.instance(root).get()
|
|
defer:
|
|
Persistency.reset()
|
|
discard p.openJob("a").get()
|
|
let j = p["a"]
|
|
check j.id == "a"
|
|
|
|
asyncTest "string-lookup persistPut + get round-trips without a Job ref":
|
|
let root = tmpRoot("rw")
|
|
defer:
|
|
removeDir(root)
|
|
let p = Persistency.instance(root).get()
|
|
defer:
|
|
Persistency.reset()
|
|
discard p.openJob("svc").get()
|
|
|
|
let k = key("c", 1'i64)
|
|
await p.persistPut("svc", "msg", k, payloadBytes("hello"))
|
|
let ckOk1 = await p.waitUntilExists("svc", "msg", k)
|
|
check ckOk1
|
|
|
|
let aw1 = await p.get("svc", "msg", k)
|
|
let got = aw1.get()
|
|
check got.isSome
|
|
check str(got.get) == "hello"
|
|
|
|
asyncTest "string-lookup reads short-circuit with peJobNotFound":
|
|
let root = tmpRoot("missingread")
|
|
defer:
|
|
removeDir(root)
|
|
let p = Persistency.instance(root).get()
|
|
defer:
|
|
Persistency.reset()
|
|
|
|
let g = await p.get("nope", "msg", key("k"))
|
|
check g.isErr
|
|
check g.error.kind == peJobNotFound
|
|
|
|
let c = await p.count("nope", "msg", prefixRange(key("k")))
|
|
check c.isErr
|
|
check c.error.kind == peJobNotFound
|
|
|
|
let d = await p.deleteAcked("nope", "msg", key("k"))
|
|
check d.isErr
|
|
check d.error.kind == peJobNotFound
|
|
|
|
asyncTest "string-lookup writes to an unknown job are dropped, not raised":
|
|
let root = tmpRoot("missingwrite")
|
|
defer:
|
|
removeDir(root)
|
|
let p = Persistency.instance(root).get()
|
|
defer:
|
|
Persistency.reset()
|
|
|
|
# Should not raise and should not leak any state.
|
|
await p.persistPut("ghost", "msg", key("k"), payloadBytes("v"))
|
|
await p.persistDelete("ghost", "msg", key("k"))
|
|
await p.persistEncoded("ghost", "msg", key("k"), 42'i64)
|
|
check not p.hasJob("ghost")
|
|
|
|
asyncTest "string-lookup persistEncoded round-trips a struct":
|
|
let root = tmpRoot("encoded")
|
|
defer:
|
|
removeDir(root)
|
|
type Item = object
|
|
tag: string
|
|
n: int64
|
|
|
|
let p = Persistency.instance(root).get()
|
|
defer:
|
|
Persistency.reset()
|
|
discard p.openJob("e").get()
|
|
|
|
let k = key("items", 1'i64)
|
|
await p.persistEncoded("e", "msg", k, Item(tag: "alpha", n: 7))
|
|
let ckOk2 = await p.waitUntilExists("e", "msg", k)
|
|
check ckOk2
|
|
|
|
let aw2 = await p.get("e", "msg", k)
|
|
let got = aw2.get()
|
|
check got.isSome
|
|
check got.get == toPayload(Item(tag: "alpha", n: 7))
|
|
|
|
asyncTest "string-lookup scan returns the same rows as Job-form":
|
|
let root = tmpRoot("scan")
|
|
defer:
|
|
removeDir(root)
|
|
let p = Persistency.instance(root).get()
|
|
defer:
|
|
Persistency.reset()
|
|
let j = p.openJob("s").get()
|
|
|
|
for i in 1'i64 .. 3:
|
|
await p.persistPut("s", "msg", key("c", i), payloadBytes($i))
|
|
let ckOk3 = await p.waitUntilExists("s", "msg", key("c", 3'i64))
|
|
check ckOk3
|
|
|
|
let aw3 = await p.scanPrefix("s", "msg", key("c"))
|
|
let viaId = aw3.get()
|
|
let aw4 = await j.scanPrefix("msg", key("c"))
|
|
let viaRef = aw4.get()
|
|
check viaId.len == viaRef.len
|
|
for i in 0 ..< viaId.len:
|
|
check viaId[i].key == viaRef[i].key
|
|
check viaId[i].payload == viaRef[i].payload
|