chore: update changelog for v0.33.1 (#3088)

CHANGELOG.md

@@ -1,3 +1,19 @@
+## v0.33.1 (2024-10-03)
+
+### Bug fixes
+
+* Fix out connections leak ([3077](https://github.com/waku-org/nwaku/pull/3077)) ([eb2bbae6](https://github.com/waku-org/nwaku/commit/eb2bbae6))
+
+This release supports the following [libp2p protocols](https://docs.libp2p.io/concepts/protocols/):
+| Protocol | Spec status | Protocol id |
+| ---: | :---: | :--- |
+| [`11/WAKU2-RELAY`](https://github.com/vacp2p/rfc-index/blob/main/waku/standards/core/11/relay.md) | `stable` | `/vac/waku/relay/2.0.0` |
+| [`12/WAKU2-FILTER`](https://github.com/vacp2p/rfc-index/blob/main/waku/standards/core/12/filter.md) | `draft` | `/vac/waku/filter/2.0.0-beta1` <br />`/vac/waku/filter-subscribe/2.0.0-beta1` <br />`/vac/waku/filter-push/2.0.0-beta1` |
+| [`13/WAKU2-STORE`](https://github.com/vacp2p/rfc-index/blob/main/waku/standards/core/13/store.md) | `draft` | `/vac/waku/store/2.0.0-beta4` |
+| [`19/WAKU2-LIGHTPUSH`](https://github.com/vacp2p/rfc-index/blob/main/waku/standards/core/19/lightpush.md) | `draft` | `/vac/waku/lightpush/2.0.0-beta1` |
+| [`66/WAKU2-METADATA`](https://github.com/waku-org/specs/blob/master/standards/core/metadata.md) | `raw` | `/vac/waku/metadata/1.0.0` |
+| [`WAKU-SYNC`](https://github.com/waku-org/specs/blob/feat--waku-sync/standards/core/sync.md) | `draft` | `/vac/waku/sync/1.0.0` |
+
 ## v0.33.0 (2024-09-30)
 
 #### Notes:

waku/node/peer_manager/peer_manager.nim

@@ -399,9 +399,11 @@ proc onPeerMetadata(pm: PeerManager, peerId: PeerId) {.async.} =
   asyncSpawn(pm.switch.disconnect(peerId))
   pm.peerStore.delete(peerId)
 
-proc connectedPeers*(pm: PeerManager, protocol: string): (seq[PeerId], seq[PeerId]) =
-  ## Returns the peerIds of physical connections (in and out)
-  ## containing at least one stream with the given protocol.
+proc connectedPeers*(
+    pm: PeerManager, protocol: string = ""
+): (seq[PeerId], seq[PeerId]) =
+  ## Returns the peerIds of physical connections (in and out)
+  ## If a protocol is specified, only returns peers with at least one stream of that protocol
 
   var inPeers: seq[PeerId]
   var outPeers: seq[PeerId]
@@ -409,7 +411,7 @@ proc connectedPeers*(pm: PeerManager, protocol: string): (seq[PeerId], seq[PeerI
   for peerId, muxers in pm.switch.connManager.getConnections():
     for peerConn in muxers:
       let streams = peerConn.getStreams()
-      if streams.anyIt(it.protocol == protocol):
+      if protocol.len == 0 or streams.anyIt(it.protocol == protocol):
         if peerConn.connection.transportDir == Direction.In:
           inPeers.add(peerId)
         elif peerConn.connection.transportDir == Direction.Out:

waku/node/waku_node.nim

@@ -1239,16 +1239,19 @@ proc mountLibp2pPing*(node: WakuNode) {.async: (raises: []).} =
 # TODO: Move this logic to PeerManager
 proc keepaliveLoop(node: WakuNode, keepalive: chronos.Duration) {.async.} =
   while node.started:
-    # Keep all connected peers alive while running
+    # Keep connected peers alive while running
+    # Each node is responsible of keeping its outgoing connections alive
     trace "Running keepalive"
 
     # First get a list of connected peer infos
-    let peers =
-      node.peerManager.peerStore.peers().filterIt(it.connectedness == Connected)
+    let outPeers = node.peerManager.connectedPeers()[1]
 
-    for peer in peers:
+    for peerId in outPeers:
       try:
-        let conn = await node.switch.dial(peer.peerId, peer.addrs, PingCodec)
+        info "calling keepAlive dial", peerId = peerId
+        let conn = (await node.peerManager.dialPeer(peerId, PingCodec)).valueOr:
+          warn "Failed dialing peer for keep alive", peerId = peerId
+          continue
         let pingDelay = await node.libp2pPing.ping(conn)
         await conn.close()
       except CatchableError as exc: