Three open PRs in logos-delivery-interop-tests add 19 channel-API tests
(RC07-RC09 #203, RC10-RC12 #209, RC13 #212). Their wrapper API surface is
already covered here, but the pieces they import were not, so those tests could
not be written in core. This ports them.
subprocess_node.py, rc05/rc06 and the closed-channel test come from interop
master; the two wrapper_helpers additions are byte-identical to what #209/#212
add, so the RC07-RC13 ports apply cleanly.
Why a spawned subprocess: co-located nodes both default localStoragePath to
./data and share data/sds.db, so the receiver drops the sender's own channel
message as a duplicate. The interop rationale blaming a process-wide Persistency
singleton is false since #4109 made Persistency per-node; the shared storage path
is the cause, and chdir to a private temp dir is what isolates it. A per-node
localStoragePath would likely replace the spawn machinery, but RC07-RC13 build on
the ported form.
Why the re-subscribe in the closed-channel test: channel_close unsubscribes the
content topic and subscriptions are not refcounted (#4081, tracked in #4087), so
the receiver re-subscribes to keep message_received as the arrival witness. This
follows the resolution in the still-open interop PR #212.
Non-docker collection goes 48 -> 51; README updated. Suite: 48 passed, 2 skipped,
1 xfailed, verified over two back-to-back runs.
* test(e2e): port remaining wrapper tests from the interop repo
The wrapper suite that moved into tests-e2e (#4027) was a reworked subset of
the one still living in logos-delivery-interop-tests. Comparing both sides
showed 21 tests here against 46 there, with no overlap in the delta: the 25
missing tests cover scenarios the reworked set never included.
Ports those 25 tests, bringing the in-repo suite to the full 46:
- 12 send scenarios: s01 (nil/destroyed handle), s03, s04, s05, s11, s13,
s16, s18 (both orderings), s25, s29
- 7 channel lifecycle tests (rc01-rc04)
- 6 wrapper corner cases: auto port allocation, MyBoundPorts, ENR
Supporting changes the ported tests need:
- wrapper_helpers: get_node_tcp_port, get_node_bound_ports, enr_udp_port
- WrapperManager: channel_create/send/close, destroy_keep_ctx
- vendored binding refreshed to the revision exposing the channel API
(additive only; cffi resolves symbols lazily, so nothing existing moves)
Two Edge senders were fixed while porting. build_node_config defaults relay
and store to True, and the flat-JSON config path applies mode=Edge before
explicit fields, so those defaults win: the Edge nodes in s11/s16/s25 came up
as relay and store servers and exercised the relay path instead of lightpush.
They now set relay=False and store=False, matching test_send_e2e_part2. s16
also dropped lightpush=True, which mounts the lightpush server and fails node
start once relay is off; the lightpush client mounts unconditionally.
Suite goes from 21 to 46 functions (53 collected). The docker subset grows
from 3 to 5 as s11 and s25 need a store peer. Local run against a freshly
built library: 45 passed, 2 skipped, 1 xfailed.
* test(e2e): enable autosharding in the channel lifecycle tests
channel_create subscribes to the channel's content topic since #4081, and
resolving that topic to a shard needs autosharding. build_node_config leaves
numShardsInNetwork at 0 and cluster 198 has no preset, so these nodes came up
with static sharding and every channel_create failed with "autosharding is not
configured; pass an explicit shard".
Adds numShardsInNetwork=1 to the six tests that create a channel, matching what
every other wrapper test that touches the send or channel API already does.
rc02 is left alone: channel_send rejects on the id lookup before any shard is
resolved.
Verified locally against a fresh build: the five tests that complete now pass
and the error string is gone from the run.
Migrate the liblogosdelivery API/wrapper pytest suite into tests-e2e/ and run it in CI (e2e-api-tests.yml) against the built library. Edge senders use the real lightpush path (relay=False).
Egor Rachkovskii