From fe8327627ee15984bbecef4ca2864bcb7ab2a9b6 Mon Sep 17 00:00:00 2001
From: NagyZoltanPeter <113987313+NagyZoltanPeter@users.noreply.github.com>
Date: Thu, 27 Mar 2025 11:56:44 +0100
Subject: [PATCH] Make /debug endpoints /version and /info available as root
 (#3333)

---
 tests/wakunode_rest/test_rest_debug.nim |  4 ++--
 waku/waku_api/rest/debug/client.nim     |  4 ++--
 waku/waku_api/rest/debug/handlers.nim   | 19 ++++++++++++++++---
 3 files changed, 20 insertions(+), 7 deletions(-)

diff --git a/tests/wakunode_rest/test_rest_debug.nim b/tests/wakunode_rest/test_rest_debug.nim
index 1d7359f68..f4e66eb20 100644
--- a/tests/wakunode_rest/test_rest_debug.nim
+++ b/tests/wakunode_rest/test_rest_debug.nim
@@ -33,7 +33,7 @@ proc testWakuNode(): WakuNode =
   newTestWakuNode(privkey, bindIp, port, some(extIp), some(port))
 
 suite "Waku v2 REST API - Debug":
-  asyncTest "Get node info - GET /debug/v1/info":
+  asyncTest "Get node info - GET /info":
     # Given
     let node = testWakuNode()
     await node.start()
@@ -62,7 +62,7 @@ suite "Waku v2 REST API - Debug":
     await restServer.closeWait()
     await node.stop()
 
-  asyncTest "Get node version - GET /debug/v1/version":
+  asyncTest "Get node version - GET /version":
     # Given
     let node = testWakuNode()
     await node.start()
diff --git a/waku/waku_api/rest/debug/client.nim b/waku/waku_api/rest/debug/client.nim
index cc8c0883b..7048ae98f 100644
--- a/waku/waku_api/rest/debug/client.nim
+++ b/waku/waku_api/rest/debug/client.nim
@@ -11,10 +11,10 @@ logScope:
 
 # TODO: Check how we can use a constant to set the method endpoint (improve "rest" pragma under nim-presto)
 proc debugInfoV1*(): RestResponse[DebugWakuInfo] {.
-  rest, endpoint: "/debug/v1/info", meth: HttpMethod.MethodGet
+  rest, endpoint: "/info", meth: HttpMethod.MethodGet
 .}
 
 # TODO: Check how we can use a constant to set the method endpoint (improve "rest" pragma under nim-presto)
 proc debugVersionV1*(): RestResponse[string] {.
-  rest, endpoint: "/debug/v1/version", meth: HttpMethod.MethodGet
+  rest, endpoint: "/version", meth: HttpMethod.MethodGet
 .}
diff --git a/waku/waku_api/rest/debug/handlers.nim b/waku/waku_api/rest/debug/handlers.nim
index fa55f0372..4ae90d007 100644
--- a/waku/waku_api/rest/debug/handlers.nim
+++ b/waku/waku_api/rest/debug/handlers.nim
@@ -8,10 +8,12 @@ export types
 logScope:
   topics = "waku node rest debug_api"
 
-const ROUTE_DEBUG_INFOV1* = "/debug/v1/info"
+const ROUTE_INFOV1* = "/info"
+# /debug route is deprecated, will be removed
+const ROUTE_DEBUG_INFOV1 = "/debug/v1/info"
 
 proc installDebugInfoV1Handler(router: var RestRouter, node: WakuNode) =
-  router.api(MethodGet, ROUTE_DEBUG_INFOV1) do() -> RestApiResponse:
+  let getInfo = proc(): RestApiResponse =
     let info = node.info().toDebugWakuInfo()
     let resp = RestApiResponse.jsonResponse(info, status = Http200)
     if resp.isErr():
@@ -20,11 +22,22 @@ proc installDebugInfoV1Handler(router: var RestRouter, node: WakuNode) =
 
     return resp.get()
 
-const ROUTE_DEBUG_VERSIONV1* = "/debug/v1/version"
+  # /debug route is deprecated, will be removed
+  router.api(MethodGet, ROUTE_DEBUG_INFOV1) do() -> RestApiResponse:
+    return getInfo()
+  router.api(MethodGet, ROUTE_INFOV1) do() -> RestApiResponse:
+    return getInfo()
+
+const ROUTE_VERSIONV1* = "/version"
+# /debug route is deprecated, will be removed
+const ROUTE_DEBUG_VERSIONV1 = "/debug/v1/version"
 
 proc installDebugVersionV1Handler(router: var RestRouter, node: WakuNode) =
+  # /debug route is deprecated, will be removed
   router.api(MethodGet, ROUTE_DEBUG_VERSIONV1) do() -> RestApiResponse:
     return RestApiResponse.textResponse(git_version, status = Http200)
+  router.api(MethodGet, ROUTE_VERSIONV1) do() -> RestApiResponse:
+    return RestApiResponse.textResponse(git_version, status = Http200)
 
 proc installDebugApiHandlers*(router: var RestRouter, node: WakuNode) =
   installDebugInfoV1Handler(router, node)