diff --git a/waku/waku_rln_relay/group_manager/on_chain/group_manager.nim b/waku/waku_rln_relay/group_manager/on_chain/group_manager.nim index 118e6c5ab..f85145ad6 100644 --- a/waku/waku_rln_relay/group_manager/on_chain/group_manager.nim +++ b/waku/waku_rln_relay/group_manager/on_chain/group_manager.nim @@ -637,7 +637,7 @@ proc startOnchainSync( var currentLatestBlock: BlockNumber g.retryWrapper(currentLatestBlock, "Failed to get the latest block number"): cast[BlockNumber](await ethRpc.provider.eth_blockNumber()) - + try: # we always want to sync from last processed block => latest # chunk events @@ -646,11 +646,10 @@ proc startOnchainSync( # then fetch the new toBlock if fromBlock >= currentLatestBlock: break - + if fromBlock + blockChunkSize.uint > currentLatestBlock.uint: g.retryWrapper(currentLatestBlock, "Failed to get the latest block number"): cast[BlockNumber](await ethRpc.provider.eth_blockNumber()) - let toBlock = min(fromBlock + BlockNumber(blockChunkSize), currentLatestBlock) debug "fetching events", fromBlock = fromBlock, toBlock = toBlock diff --git a/waku/waku_rln_relay/group_manager/on_chain/retry_wrapper.nim b/waku/waku_rln_relay/group_manager/on_chain/retry_wrapper.nim index 74c744ab2..1391599bc 100644 --- a/waku/waku_rln_relay/group_manager/on_chain/retry_wrapper.nim +++ b/waku/waku_rln_relay/group_manager/on_chain/retry_wrapper.nim @@ -13,7 +13,7 @@ template retryWrapper*( res: auto, retryStrategy: RetryStrategy, errStr: string, - errCallback: OnFatalErrorHandler = nil, + errCallback: OnFatalErrorHandler, body: untyped, ): auto = var retryCount = retryStrategy.retryCount @@ -29,10 +29,5 @@ template retryWrapper*( exceptionMessage = getCurrentExceptionMsg() await sleepAsync(retryStrategy.retryDelay) if shouldRetry: - if errCallback == nil: - raise newException( - CatchableError, errStr & " errCallback == nil: " & exceptionMessage - ) - else: - errCallback(errStr & ": " & exceptionMessage) - return + errCallback(errStr & ": " & exceptionMessage) + return