From f60bd311cc725cc56d2fb0486793fcf5841e553d Mon Sep 17 00:00:00 2001 From: Sergei Tikhomirov Date: Thu, 6 Mar 2025 11:05:39 +0100 Subject: [PATCH] initialize ReputationManager inside new() --- tests/waku_lightpush/lightpush_utils.nim | 7 +------ waku/waku_lightpush/client.nim | 7 ++++++- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/waku_lightpush/lightpush_utils.nim b/tests/waku_lightpush/lightpush_utils.nim index 4be10ea2b..5c3e78764 100644 --- a/tests/waku_lightpush/lightpush_utils.nim +++ b/tests/waku_lightpush/lightpush_utils.nim @@ -30,9 +30,4 @@ proc newTestWakuLightpushClient*( reputationEnabled: bool = false ): WakuLightPushClient = let peerManager = PeerManager.new(switch) - let reputationManager = - if reputationEnabled: - some(ReputationManager.new()) - else: - none(ReputationManager) - WakuLightPushClient.new(peerManager, rng, reputationManager) + WakuLightPushClient.new(peerManager, rng, reputationEnabled) diff --git a/waku/waku_lightpush/client.nim b/waku/waku_lightpush/client.nim index ab513ab8f..a7f32076c 100644 --- a/waku/waku_lightpush/client.nim +++ b/waku/waku_lightpush/client.nim @@ -27,8 +27,13 @@ proc new*( T: type WakuLightPushClient, peerManager: PeerManager, rng: ref rand.HmacDrbgContext, - reputationManager: Option[ReputationManager], + reputationEnabled: bool, ): T = + let reputationManager = + if reputationEnabled: + some(ReputationManager.new()) + else: + none(ReputationManager) WakuLightPushClient( peerManager: peerManager, rng: rng, reputationManager: reputationManager )