From f0f94412a0ea856a1c3ff6ed255eb6a7ae71a503 Mon Sep 17 00:00:00 2001 From: Ivan FB <128452529+Ivansete-status@users.noreply.github.com> Date: Thu, 16 May 2024 18:04:04 +0200 Subject: [PATCH] test_client: simple sleep to try avoid macos CI test failures (#2707) --- tests/waku_store/test_client.nim | 17 ++++++++++------- tests/waku_store_legacy/test_client.nim | 17 ++++++++++------- 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/tests/waku_store/test_client.nim b/tests/waku_store/test_client.nim index b1bfb1cb8..b4ba91a99 100644 --- a/tests/waku_store/test_client.nim +++ b/tests/waku_store/test_client.nim @@ -74,13 +74,16 @@ suite "Store Client": await allFutures(serverSwitch.start(), clientSwitch.start()) - if serverSwitch.peerInfo.isNil(): - error "serverSwitch.peerInfo is nil" - raise newException(CatchableError, "serverSwitch.peerInfo is nil") - - if clientSwitch.peerInfo.isNil(): - error "clientSwitch.peerInfo is nil" - raise newException(CatchableError, "clientSwitch.peerInfo is nil") + ## The following sleep is aimed to prevent macos failures in CI + #[ +2024-05-16T13:24:45.5106200Z INF 2024-05-16 13:24:45.509+00:00 Stopping AutonatService topics="libp2p autonatservice" tid=53712 file=service.nim:203 +2024-05-16T13:24:45.5107960Z WRN 2024-05-16 13:24:45.509+00:00 service is already stopped topics="libp2p switch" tid=53712 file=switch.nim:86 +2024-05-16T13:24:45.5109010Z . (1.68s) +2024-05-16T13:24:45.5109320Z Store Client (0.00s) +2024-05-16T13:24:45.5109870Z SIGSEGV: Illegal storage access. (Attempt to read from nil?) +2024-05-16T13:24:45.5111470Z stack trace: (most recent call last) + ]# + await sleepAsync(500.millis) serverPeerInfo = serverSwitch.peerInfo.toRemotePeerInfo() clientPeerInfo = clientSwitch.peerInfo.toRemotePeerInfo() diff --git a/tests/waku_store_legacy/test_client.nim b/tests/waku_store_legacy/test_client.nim index 5efef77f1..7b52a623a 100644 --- a/tests/waku_store_legacy/test_client.nim +++ b/tests/waku_store_legacy/test_client.nim @@ -54,13 +54,16 @@ suite "Store Client": await allFutures(serverSwitch.start(), clientSwitch.start()) - if serverSwitch.peerInfo.isNil(): - error "serverSwitch.peerInfo is nil" - raise newException(CatchableError, "serverSwitch.peerInfo is nil") - - if clientSwitch.peerInfo.isNil(): - error "clientSwitch.peerInfo is nil" - raise newException(CatchableError, "clientSwitch.peerInfo is nil") + ## The following sleep is aimed to prevent macos failures in CI + #[ +2024-05-16T13:24:45.5106200Z INF 2024-05-16 13:24:45.509+00:00 Stopping AutonatService topics="libp2p autonatservice" tid=53712 file=service.nim:203 +2024-05-16T13:24:45.5107960Z WRN 2024-05-16 13:24:45.509+00:00 service is already stopped topics="libp2p switch" tid=53712 file=switch.nim:86 +2024-05-16T13:24:45.5109010Z . (1.68s) +2024-05-16T13:24:45.5109320Z Store Client (0.00s) +2024-05-16T13:24:45.5109870Z SIGSEGV: Illegal storage access. (Attempt to read from nil?) +2024-05-16T13:24:45.5111470Z stack trace: (most recent call last) + ]# + await sleepAsync(500.millis) serverPeerInfo = serverSwitch.peerInfo.toRemotePeerInfo() clientPeerInfo = clientSwitch.peerInfo.toRemotePeerInfo()