From e249c99216dd3c60e77b4d25dbae8506718ea933 Mon Sep 17 00:00:00 2001
From: Ivan Folgueira Bande <ivansete@status.im>
Date: Thu, 24 Oct 2024 11:16:14 +0200
Subject: [PATCH] dbconn: make sure fd is not registered before registering
 again

---
 waku/common/databases/db_postgres/dbconn.nim | 23 ++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/waku/common/databases/db_postgres/dbconn.nim b/waku/common/databases/db_postgres/dbconn.nim
index 243c195c3..20ede5894 100644
--- a/waku/common/databases/db_postgres/dbconn.nim
+++ b/waku/common/databases/db_postgres/dbconn.nim
@@ -167,7 +167,7 @@ proc sendQueryPrepared(
   return ok()
 
 proc waitQueryToFinish(
-    dbConnWrapper: DbConnWrapper, rowCallback: DataProc = nil
+    dbConnWrapper: DbConnWrapper, rowCallback: DataProc = nil, query: string
 ): Future[Result[void, string]] {.async.} =
   ## The 'rowCallback' param is != nil when the underlying query wants to retrieve results (SELECT.)
   ## For other queries, like "INSERT", 'rowCallback' should be nil.
@@ -180,9 +180,24 @@ proc waitQueryToFinish(
 
   let asyncFd = cast[asyncengine.AsyncFD](pqsocket(dbConnWrapper.dbConn))
 
+  let loop = asyncengine.getThreadDispatcher()
+  if loop.contains(asyncFd):
+    warn "The fd was already registerd", query
+    asyncengine.removeReader2(asyncFd).isOkOr:
+      error "failed to remove fd even after it beeing already registered",
+        query, error = $error
+      return err(
+        "failed to remove fd even after it beeing already registered. query: " & query &
+          ". error: " & $error
+      )
+
   asyncengine.addReader2(asyncFd, onDataAvailable).isOkOr:
     dbConnWrapper.futBecomeFree.fail(newException(ValueError, $error))
-    return err("failed to add event reader in waitQueryToFinish: " & $error)
+    error "failed to add event reader in waitQueryToFinish", query, error = $error
+    return err(
+      "failed to add event reader in waitQueryToFinish. query: " & query & " : error. " &
+        $error
+    )
   defer:
     asyncengine.removeReader2(asyncFd).isOkOr:
       return err("failed to remove event reader in waitQueryToFinish: " & $error)
@@ -264,7 +279,7 @@ proc dbConnQuery*(
 
   queryStartTime = getTime().toUnixFloat()
 
-  (await dbConnWrapper.waitQueryToFinish(rowCallback)).isOkOr:
+  (await dbConnWrapper.waitQueryToFinish(rowCallback, $query)).isOkOr:
     return err("error in dbConnQuery calling waitQueryToFinish: " & $error)
 
   let waitDuration = getTime().toUnixFloat() - queryStartTime
@@ -305,7 +320,7 @@ proc dbConnQueryPrepared*(
 
   queryStartTime = getTime().toUnixFloat()
 
-  (await dbConnWrapper.waitQueryToFinish(rowCallback)).isOkOr:
+  (await dbConnWrapper.waitQueryToFinish(rowCallback, stmtName)).isOkOr:
     return err("error in dbConnQueryPrepared calling waitQueryToFinish: " & $error)
 
   let waitDuration = getTime().toUnixFloat() - queryStartTime