From df66fcd2794770befd51de137a1db90e6bb67529 Mon Sep 17 00:00:00 2001
From: Sergei Tikhomirov <sergey.s.tikhomirov@gmail.com>
Date: Tue, 11 Mar 2025 20:04:15 +0100
Subject: [PATCH] adapt reputation tests to Lightpush v3 response type

---
 tests/incentivization/test_poc_reputation.nim | 37 +++++++++++++------
 waku/node/waku_node.nim                       |  3 +-
 2 files changed, 28 insertions(+), 12 deletions(-)

diff --git a/tests/incentivization/test_poc_reputation.nim b/tests/incentivization/test_poc_reputation.nim
index ec0856fef..ad1fa3bae 100644
--- a/tests/incentivization/test_poc_reputation.nim
+++ b/tests/incentivization/test_poc_reputation.nim
@@ -12,7 +12,7 @@ import
 import
   waku/[node/peer_manager, waku_core],
   waku/incentivization/[rpc, reputation_manager],
-  waku/waku_lightpush_legacy/rpc
+  waku/waku_lightpush/[rpc, common]
 
 suite "Waku Incentivization PoC Reputation":
   var manager {.threadvar.}: ReputationManager
@@ -29,23 +29,38 @@ suite "Waku Incentivization PoC Reputation":
     manager.setReputation(peerId1, some(true)) # Encodes GoodRep
     check manager.getReputation(peerId1) == some(true)
 
-  test "incentivization PoC: reputation: evaluate PushResponse valid":
-    let validLightpushResponse =
-      PushResponse(isSuccess: true, info: some("Everything is OK"))
-    # We expect evaluateResponse to return GoodResponse if isSuccess is true
-    check evaluateResponse(validLightpushResponse) == GoodResponse
+  #[
+    LightPushResponse* = object
+    requestId*: string
+    statusCode*: uint32
+    statusDesc*: Option[string]
+    relayPeerCount*: Option[uint32]
 
-  test "incentivization PoC: reputation: evaluate PushResponse invalid":
-    let invalidLightpushResponse = PushResponse(isSuccess: false, info: none(string))
-    check evaluateResponse(invalidLightpushResponse) == BadResponse
+    LightpushStatusCode
+    ]#
+
+  test "incentivization PoC: reputation: evaluate LightPushResponse valid":
+    let validLightLightPushResponse =
+      LightPushResponse(requestId: "", statusCode: LightpushStatusCode.SUCCESS.uint32)
+    # We expect evaluateResponse to return GoodResponse if isSuccess is true
+    check evaluateResponse(validLightLightPushResponse) == GoodResponse
+
+  test "incentivization PoC: reputation: evaluate LightPushResponse invalid":
+    let invalidLightLightPushResponse = LightPushResponse(
+      requestId: "", statusCode: LightpushStatusCode.SERVICE_NOT_AVAILABLE.uint32
+    )
+    check evaluateResponse(invalidLightLightPushResponse) == BadResponse
 
   test "incentivization PoC: reputation: updateReputationFromResponse valid":
-    let validResp = PushResponse(isSuccess: true, info: some("All good"))
+    let validResp =
+      LightPushResponse(requestId: "", statusCode: LightpushStatusCode.SUCCESS.uint32)
     manager.updateReputationFromResponse(peerId1, validResp)
     check manager.getReputation(peerId1) == some(true)
 
   test "incentivization PoC: reputation: updateReputationFromResponse invalid":
-    let invalidResp = PushResponse(isSuccess: false, info: none(string))
+    let invalidResp = LightPushResponse(
+      requestId: "", statusCode: LightpushStatusCode.SERVICE_NOT_AVAILABLE.uint32
+    )
     manager.updateReputationFromResponse(peerId1, invalidResp)
     check manager.getReputation(peerId1) == some(false)
 
diff --git a/waku/node/waku_node.nim b/waku/node/waku_node.nim
index e10d705ff..c7bef00f9 100644
--- a/waku/node/waku_node.nim
+++ b/waku/node/waku_node.nim
@@ -1124,7 +1124,8 @@ proc mountLightPush*(
 proc mountLightPushClient*(node: WakuNode) =
   info "mounting light push client"
 
-  node.wakuLightpushClient = WakuLightPushClient.new(node.peerManager, node.rng)
+  node.wakuLightpushClient =
+    WakuLightPushClient.new(node.peerManager, node.rng, reputationEnabled = false)
 
 proc lightpushPublishHandler(
     node: WakuNode,