From b839a1c47b7c418507bccafa17ea2d3c31d3c39a Mon Sep 17 00:00:00 2001 From: fryorcraken Date: Mon, 1 Jul 2024 13:05:15 +1000 Subject: [PATCH] feat!: change default eth client value to empty string Does not really make sense to have a default value set to localhost and assume user has a local eth node running. On the contrary, this can lead to issue where user doesn't understand why the node tries to connect to localhost. --- waku/factory/external_config.nim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/waku/factory/external_config.nim b/waku/factory/external_config.nim index 652b76373..b759ebf75 100644 --- a/waku/factory/external_config.nim +++ b/waku/factory/external_config.nim @@ -60,14 +60,14 @@ type WakuNodeConf* = object ## RLN Relay configuration rlnRelayCredPath* {. - desc: "The path for peristing rln-relay credential", + desc: "The path for persisting rln-relay credential", defaultValue: "", name: "rln-relay-cred-path" .}: string rlnRelayEthClientAddress* {. desc: "HTTP address of an Ethereum testnet client e.g., http://localhost:8540/", - defaultValue: "http://localhost:8540/", + defaultValue: "", name: "rln-relay-eth-client-address" .}: EthRpcUrl