From a9f241e0325f95207478ade5b4d94c3d03316760 Mon Sep 17 00:00:00 2001 From: darshankabariya Date: Wed, 29 Apr 2026 03:22:02 +0530 Subject: [PATCH] feat: us prebuilt nimble to avoid koch --- .github/workflows/windows-build.yml | 10 ++++++++-- waku/waku_rln_relay/constants.nim | 2 -- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/windows-build.yml b/.github/workflows/windows-build.yml index 50f1602cd..f7c455a04 100644 --- a/.github/workflows/windows-build.yml +++ b/.github/workflows/windows-build.yml @@ -75,10 +75,16 @@ jobs: repo-token: ${{ secrets.GITHUB_TOKEN }} - name: Install Nimble ${{ env.NIMBLE_VERSION }} + # Use the prebuilt Windows binary instead of `nimble install nimble@...`, + # which triggers a koch self-bootstrap that races Windows Defender on + # bin\nim.exe and fails with "Access is denied". run: | - export PATH="$GITHUB_WORKSPACE/.nim_runtime/bin:$PATH" - cd /tmp && nimble install "nimble@${{ env.NIMBLE_VERSION }}" -y + mkdir -p "$HOME/.nimble/bin" + curl -fsSL -o /tmp/nimble.zip \ + "https://github.com/nim-lang/nimble/releases/download/v${{ env.NIMBLE_VERSION }}/nimble-windows_x64.zip" + unzip -o /tmp/nimble.zip -d "$HOME/.nimble/bin" echo "$HOME/.nimble/bin" >> $GITHUB_PATH + "$HOME/.nimble/bin/nimble.exe" --version - name: Patch nimble.lock for Windows nim checksum # nimble.exe uses Windows Git (core.autocrlf=true by default), which converts LF→CRLF diff --git a/waku/waku_rln_relay/constants.nim b/waku/waku_rln_relay/constants.nim index 8b365ed68..3e4757537 100644 --- a/waku/waku_rln_relay/constants.nim +++ b/waku/waku_rln_relay/constants.nim @@ -7,8 +7,6 @@ import ../waku_keystore # Acceptable roots for merkle root validation of incoming messages const AcceptableRootWindowSize* = 50 -const DummyConstant* = 50 - # RLN membership key and index files path const RlnCredentialsFilename* = "rlnCredentials.txt"