From a90ccfafd08ba40b1c40764dc4a90c8d029dcfe4 Mon Sep 17 00:00:00 2001
From: Aaryamann Challani <43716372+rymnc@users.noreply.github.com>
Date: Mon, 25 Sep 2023 13:26:16 +0530
Subject: [PATCH] fix(rln-relay): segfault when no params except rln-relay is
 passed in (#2047)

---
 waku/waku_rln_relay/group_manager/static/group_manager.nim | 3 ++-
 waku/waku_rln_relay/rln_relay.nim                          | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/waku/waku_rln_relay/group_manager/static/group_manager.nim b/waku/waku_rln_relay/group_manager/static/group_manager.nim
index 9aa81d952..3274975de 100644
--- a/waku/waku_rln_relay/group_manager/static/group_manager.nim
+++ b/waku/waku_rln_relay/group_manager/static/group_manager.nim
@@ -19,7 +19,8 @@ method init*(g: StaticGroupManager): Future[void] {.async,gcsafe.} =
   let
     groupSize = g.groupSize
     groupKeys = g.groupKeys
-    membershipIndex = g.membershipIndex.get()
+    membershipIndex = if g.membershipIndex.isSome(): g.membershipIndex.get() 
+                      else: raise newException(ValueError, "Membership index is not set") 
 
   if membershipIndex < MembershipIndex(0) or membershipIndex >= MembershipIndex(groupSize):
     raise newException(ValueError, "Invalid membership index. Must be within 0 and " & $(groupSize - 1) & "but was " & $membershipIndex)
diff --git a/waku/waku_rln_relay/rln_relay.nim b/waku/waku_rln_relay/rln_relay.nim
index 15a85348b..72dff801d 100644
--- a/waku/waku_rln_relay/rln_relay.nim
+++ b/waku/waku_rln_relay/rln_relay.nim
@@ -408,7 +408,7 @@ proc isReady*(rlnPeer: WakuRLNRelay): Future[bool] {.async.} =
 
 proc new*(T: type WakuRlnRelay,
           conf: WakuRlnConfig,
-          registrationHandler: Option[RegistrationHandler] = none(RegistrationHandler)
+          registrationHandler = none(RegistrationHandler)
           ): Future[RlnRelayResult[WakuRlnRelay]] {.async.} =
   ## Mounts the rln-relay protocol on the node.
   ## The rln-relay protocol can be mounted in two modes: on-chain and off-chain.