logos-messaging/logos-messaging-nim
1
0
Fork 0
mirror of https://github.com/logos-messaging/logos-messaging-nim.git synced 2026-01-04 06:53:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update error handling in rln group-manager tests

Browse Source
This commit is contained in:
stubbsta 2025-12-19 09:01:51 +02:00
parent 879c79161f
commit a87cb50e3e
No known key found for this signature in database
2 changed files with 20 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
tests/waku_rln_relay/test_rln_group_manager_onchain.nim
View File

@ -86,10 +86,8 @@ suite "Onchain group manager":
let merkleRootBefore = waitFor manager.fetchMerkleRoot() let merkleRootBefore = waitFor manager.fetchMerkleRoot()
try: (waitFor manager.register(credentials, UserMessageLimit(20))).isOkOr:
waitFor manager.register(credentials, UserMessageLimit(20)) raiseAssert "Failed to register: " & error
except Exception, CatchableError:
assert false, "exception raised: " & getCurrentExceptionMsg()
discard waitFor withTimeout(trackRootChanges(manager), 15.seconds) discard waitFor withTimeout(trackRootChanges(manager), 15.seconds)
@ -110,13 +108,11 @@ suite "Onchain group manager":
let merkleRootBefore = waitFor manager.fetchMerkleRoot() let merkleRootBefore = waitFor manager.fetchMerkleRoot()
try: for i in 0 ..< credentials.len():
for i in 0 ..< credentials.len(): info "Registering credential", index = i, credential = credentials[i]
info "Registering credential", index = i, credential = credentials[i] (waitFor manager.register(credentials[i], UserMessageLimit(20))).isOkOr:
waitFor manager.register(credentials[i], UserMessageLimit(20)) raiseAssert "Failed to register credential " & $i & ": " & error
discard waitFor manager.updateRoots() discard waitFor manager.updateRoots()
except Exception, CatchableError:
assert false, "exception raised: " & getCurrentExceptionMsg()
let merkleRootAfter = waitFor manager.fetchMerkleRoot() let merkleRootAfter = waitFor manager.fetchMerkleRoot()
@ -127,16 +123,15 @@ suite "Onchain group manager":
test "register: should guard against uninitialized state": test "register: should guard against uninitialized state":
let dummyCommitment = default(IDCommitment) let dummyCommitment = default(IDCommitment)
try: let res = waitFor manager.register(
waitFor manager.register( RateCommitment(
RateCommitment( idCommitment: dummyCommitment, userMessageLimit: UserMessageLimit(20)
idCommitment: dummyCommitment, userMessageLimit: UserMessageLimit(20)
)
) )
except CatchableError: )
assert true
except Exception: check:
assert false, "exception raised: " & getCurrentExceptionMsg() res.isErr()
res.error == "Not initialized: OnchainGroupManager is not initialized"
test "register: should register successfully": test "register: should register successfully":
# TODO :- similar to ```trackRootChanges: should fetch history correctly``` # TODO :- similar to ```trackRootChanges: should fetch history correctly```
@ -146,9 +141,7 @@ suite "Onchain group manager":
let idCredentials = generateCredentials() let idCredentials = generateCredentials()
let merkleRootBefore = waitFor manager.fetchMerkleRoot() let merkleRootBefore = waitFor manager.fetchMerkleRoot()
try: (waitFor manager.register(idCredentials, UserMessageLimit(20))).isOkOr:
waitFor manager.register(idCredentials, UserMessageLimit(20))
except Exception, CatchableError:
assert false, assert false,
"exception raised when calling register: " & getCurrentExceptionMsg() "exception raised when calling register: " & getCurrentExceptionMsg()

5
tools/rln_keystore_generator/rln_keystore_generator.nim
View File

@ -73,7 +73,10 @@ proc doRlnKeystoreGenerator*(conf: RlnKeystoreGeneratorConf) =
# 4. register on-chain # 4. register on-chain
try: try:
waitFor groupManager.register(credential, conf.userMessageLimit) let registerResult = waitFor groupManager.register(credential, conf.userMessageLimit)
if registerResult.isErr():
error "Failed to register on-chain", error = registerResult.error
quit(QuitFailure)
except Exception, CatchableError: except Exception, CatchableError:
error "failure while registering credentials on-chain", error "failure while registering credentials on-chain",
error = getCurrentExceptionMsg() error = getCurrentExceptionMsg()