From 8a8c745e3038bbb4ee50df73650954c0db4bb3de Mon Sep 17 00:00:00 2001 From: Aaryamann Challani <43716372+rymnc@users.noreply.github.com> Date: Fri, 7 Oct 2022 01:47:01 +0530 Subject: [PATCH] chore(rln-relay): disable merkle root validation (#1246) * chore(rln-relay): disable merkle root validation * brings back validation of the root but without invalidating the message * adds the tracking issue Co-authored-by: sanaz --- waku/v2/protocol/waku_rln_relay/waku_rln_relay_utils.nim | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/waku/v2/protocol/waku_rln_relay/waku_rln_relay_utils.nim b/waku/v2/protocol/waku_rln_relay/waku_rln_relay_utils.nim index 6c62e7b87..58dee6af5 100644 --- a/waku/v2/protocol/waku_rln_relay/waku_rln_relay_utils.nim +++ b/waku/v2/protocol/waku_rln_relay/waku_rln_relay_utils.nim @@ -809,10 +809,11 @@ proc validateMessage*(rlnPeer: WakuRLNRelay, msg: WakuMessage, waku_rln_invalid_messages_total.inc(labelValues=["invalid_epoch"]) return MessageValidationResult.Invalid + ## TODO: FIXME after resolving this issue https://github.com/status-im/nwaku/issues/1247 if not rlnPeer.validateRoot(msg.proof.merkleRoot): debug "invalid message: provided root does not belong to acceptable window of roots", provided=msg.proof.merkleRoot, validRoots=rlnPeer.validMerkleRoots waku_rln_invalid_messages_total.inc(labelValues=["invalid_root"]) - return MessageValidationResult.Invalid + # return MessageValidationResult.Invalid # verify the proof let