From 89d66dde9a7e619afc762af28cf8a83c084e328a Mon Sep 17 00:00:00 2001 From: Hanno Cornelius <68783915+jm-clius@users.noreply.github.com> Date: Tue, 9 May 2023 09:18:14 +0200 Subject: [PATCH] fix: change filter request default behaviour to ping (#1721) --- waku/v2/waku_filter_v2/protocol.nim | 2 +- waku/v2/waku_filter_v2/rpc_codec.nim | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/waku/v2/waku_filter_v2/protocol.nim b/waku/v2/waku_filter_v2/protocol.nim index 0b99df310..fdac04124 100644 --- a/waku/v2/waku_filter_v2/protocol.nim +++ b/waku/v2/waku_filter_v2/protocol.nim @@ -222,7 +222,7 @@ proc initProtocolHandler(wf: WakuFilter) = let decodeRes = FilterSubscribeRequest.decode(buf) if decodeRes.isErr(): - error "Failed to decode filter subscribe request", peerId=conn.peerId + error "Failed to decode filter subscribe request", peerId=conn.peerId, err=decodeRes.error waku_filter_errors.inc(labelValues = [decodeRpcFailure]) return diff --git a/waku/v2/waku_filter_v2/rpc_codec.nim b/waku/v2/waku_filter_v2/rpc_codec.nim index 4de8549d0..dcd787dc2 100644 --- a/waku/v2/waku_filter_v2/rpc_codec.nim +++ b/waku/v2/waku_filter_v2/rpc_codec.nim @@ -37,7 +37,8 @@ proc decode*(T: type FilterSubscribeRequest, buffer: seq[byte]): ProtobufResult[ var filterSubscribeType: uint32 if not ?pb.getField(2, filterSubscribeType): - return err(ProtobufError.missingRequiredField("filter_subscribe_type")) + # Revert to ping by default if not set + rpc.filterSubscribeType = FilterSubscribeType.SUBSCRIBER_PING else: rpc.filterSubscribeType = FilterSubscribeType(filterSubscribeType)