From 7f337818451455b062cf9e6d7c2053b5e7856d46 Mon Sep 17 00:00:00 2001 From: darshankabariya Date: Mon, 2 Feb 2026 03:08:58 +0530 Subject: [PATCH] ci improvement - 5 --- .github/workflows/windows-build.yml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/windows-build.yml b/.github/workflows/windows-build.yml index 134b0cfb5..7e3bce647 100644 --- a/.github/workflows/windows-build.yml +++ b/.github/workflows/windows-build.yml @@ -68,21 +68,24 @@ jobs: - name: Add Nimble to MSYS2 PATH and run make update run: | # The setup-nimble-action installs to .nimble_runtime/bin but MSYS2 has its own PATH - # Save the nimble path for use in subsequent steps - echo "NIMBLE_BIN=$(pwd)/.nimble_runtime/bin" >> $GITHUB_ENV - export PATH="$(pwd)/.nimble_runtime/bin:$HOME/.nimble/bin:$PATH" + # Also need to add nim-dlls for OpenSSL DLLs (libcrypto, libssl) + export NIMBLE_BIN="$(pwd)/.nimble_runtime/bin" + export NIM_DLLS="$(pwd)/nim-dlls" + echo "NIMBLE_BIN=$NIMBLE_BIN" >> $GITHUB_ENV + echo "NIM_DLLS=$NIM_DLLS" >> $GITHUB_ENV + export PATH="$NIMBLE_BIN:$NIM_DLLS:$HOME/.nimble/bin:$PATH" which nimble nimble -v make update - name: Building wakunode2.exe run: | - export PATH="$NIMBLE_BIN:$HOME/.nimble/bin:$PATH" + export PATH="$NIMBLE_BIN:$NIM_DLLS:$HOME/.nimble/bin:$PATH" make wakunode2 LOG_LEVEL=DEBUG V=3 -j8 - name: Building libwaku.dll run: | - export PATH="$NIMBLE_BIN:$HOME/.nimble/bin:$PATH" + export PATH="$NIMBLE_BIN:$NIM_DLLS:$HOME/.nimble/bin:$PATH" make libwaku STATIC=0 LOG_LEVEL=DEBUG V=1 -j - name: Check Executable