Fix protocol connection close (#3588)

* Added connection closeWithEof for protocol handler and clients of lightpush/legacy lightpush and filter (except filer push case)
* Store/Legacy store close connections

note: this enhancement is fully made by Zoltán. Me I just resubmitted it after nwaku history cleanup.

---------

Co-authored-by: NagyZoltanPeter <113987313+NagyZoltanPeter@users.noreply.github.com>

waku/waku_filter_v2/client.nim

@@ -58,6 +58,9 @@ proc sendSubscribeRequest(
 
   let connection = connOpt.get()
 
+  defer:
+    await connection.closeWithEOF()
+
   try:
     await connection.writeLP(filterSubscribeRequest.encode().buffer)
   except CatchableError:

waku/waku_filter_v2/protocol.nim

@@ -293,6 +293,9 @@ proc initProtocolHandler(wf: WakuFilter) =
 
     var response: FilterSubscribeResponse
 
+    defer:
+      await conn.closeWithEOF()
+
     wf.peerRequestRateLimiter.checkUsageLimit(WakuFilterSubscribeCodec, conn):
       var buf: seq[byte]
       try:

waku/waku_lightpush/client.nim

@@ -43,6 +43,9 @@ proc sendPushRequest(
         dialFailure & ": " & $peer & " is not accessible",
       )
 
+  defer:
+    await connection.closeWithEOF()
+
   await connection.writeLP(req.encode().buffer)
 
   var buffer: seq[byte]

waku/waku_lightpush/protocol.nim

@@ -107,6 +107,9 @@ proc handleRequest*(
 proc initProtocolHandler(wl: WakuLightPush) =
   proc handler(conn: Connection, proto: string) {.async: (raises: [CancelledError]).} =
     var rpc: LightPushResponse
+    defer:
+      await conn.closeWithEOF()
+
     wl.requestRateLimiter.checkUsageLimit(WakuLightPushCodec, conn):
       var buffer: seq[byte]
       try:

waku/waku_lightpush_legacy/client.nim

@@ -40,6 +40,9 @@ proc sendPushRequest(
     return err(dialFailure)
   let connection = connOpt.get()
 
+  defer:
+    await connection.closeWithEOF()
+
   let rpc = PushRPC(requestId: generateRequestId(wl.rng), request: some(req))
   await connection.writeLP(rpc.encode().buffer)
 

waku/waku_lightpush_legacy/protocol.nim

@@ -67,6 +67,9 @@ proc handleRequest*(
 proc initProtocolHandler(wl: WakuLegacyLightPush) =
   proc handler(conn: Connection, proto: string) {.async: (raises: [CancelledError]).} =
     var rpc: PushRPC
+    defer:
+      await conn.closeWithEOF()
+
     wl.requestRateLimiter.checkUsageLimit(WakuLegacyLightPushCodec, conn):
       var buffer: seq[byte]
       try:

waku/waku_store/client.nim

@@ -25,6 +25,9 @@ proc sendStoreRequest(
 ): Future[StoreQueryResult] {.async, gcsafe.} =
   var req = request
 
+  defer:
+    await connection.closeWithEof()
+
   if req.requestId == "":
     req.requestId = generateRequestId(self.rng)
 

waku/waku_store/protocol.nim

@@ -92,6 +92,10 @@ proc initProtocolHandler(self: WakuStore) =
     var successfulQuery = false ## only consider the correct queries in metrics
     var resBuf: StoreResp
     var queryDuration: float
+
+    defer:
+      await conn.closeWithEof()
+
     self.requestRateLimiter.checkUsageLimit(WakuStoreCodec, conn):
       let readRes = catch:
         await conn.readLp(DefaultMaxRpcSize.int)

waku/waku_store_legacy/client.nim

@@ -43,6 +43,9 @@ proc sendHistoryQueryRPC(
 
   let connection = connOpt.get()
 
+  defer:
+    await connection.closeWithEof()
+
   let requestId =
     if req.requestId != "":
       req.requestId

waku/waku_store_legacy/protocol.nim

@@ -114,6 +114,10 @@ proc initProtocolHandler(ws: WakuStore) =
     var successfulQuery = false ## only consider the correct queries in metrics
     var resBuf: StoreResp
     var queryDuration: float
+
+    defer:
+      await conn.closeWithEof()
+
     ws.requestRateLimiter.checkUsageLimit(WakuLegacyStoreCodec, conn):
       let readRes = catch:
         await conn.readLp(DefaultMaxRpcSize.int)