From 7388134163555bf67e1df8079bc7f9b3e8989809 Mon Sep 17 00:00:00 2001 From: Aaryamann Challani <43716372+rymnc@users.noreply.github.com> Date: Wed, 2 Aug 2023 10:40:18 +0530 Subject: [PATCH] fix(rln-relay): mark duplicated messages as spam (#1867) * fix(rln-relay): mark duplicated messages as spam * chore: fix fn desc --- waku/v2/waku_rln_relay/rln_relay.nim | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/waku/v2/waku_rln_relay/rln_relay.nim b/waku/v2/waku_rln_relay/rln_relay.nim index a8deccf91..3dd3b5631 100644 --- a/waku/v2/waku_rln_relay/rln_relay.nim +++ b/waku/v2/waku_rln_relay/rln_relay.nim @@ -100,7 +100,7 @@ method stop*(rlnPeer: WakuRLNRelay) {.async.} = proc hasDuplicate*(rlnPeer: WakuRLNRelay, proofMetadata: ProofMetadata): RlnRelayResult[bool] = ## returns true if there is another message in the `nullifierLog` of the `rlnPeer` with the same - ## epoch and nullifier as `proofMetadata`'s epoch and nullifier but different Shamir secret shares + ## epoch and nullifier as `proofMetadata`'s epoch and nullifier ## otherwise, returns false ## Returns an error if it cannot check for duplicates @@ -110,8 +110,8 @@ proc hasDuplicate*(rlnPeer: WakuRLNRelay, return ok(false) try: if rlnPeer.nullifierLog[externalNullifier].contains(proofMetadata): - # there is an identical record, ignore rhe mag - return ok(false) + # there is an identical record, mark it as spam + return ok(true) # check for a message with the same nullifier but different secret shares let matched = rlnPeer.nullifierLog[externalNullifier].filterIt((